Release candidate for mbed-os-5.4.1 #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnment of system_stm32f429xx.c files
Sometimes when under heavy load, the CI machines can take a significant amount of time to bring up a python process (~10s). The timeouts for the network tests were chosen without much thought, and didn't leave much room for this sort of delay. This patch brings up timeouts for ntetwork tests 20s -> 60s
…source By default the number of pstorage pages is set 1 and all addresses are calculated in the pstorage module accordingly. Nordic recommends changing this macro to whatever number is suitable for the app (see https://devzone.nordicsemi.com/question/53066/what-will-be-the-starting- address-of-pstorage-page-how-we-can-change-it/?answer=53085#post-id-5308 5) which is not quite elegant given that pstorage_platform.h is part of the mbed-os repo. With this modification you can e.g. define PSTORAGE_NUM_OF_PAGES on the command line, however note that you should rebuild mbed-os with this setting as it affects pstorage_platform.c.
Up to now, speed was set for outputs and alternate, but this is also valid for input configuration. By default, let's configure high speed. This is done firts, because speed for some families like F1 is mixed with Input/Output mode settings, so can be later over-ridden if needed.
In case the selected frequency is higher than the requested one, it is better to send a debug warning rather than an blocking error. In case of such warning, user may need to redefine the clock tree setting at higher level (reducing peripheral's input clocks during init phase).
We have scripts (written in python) that are run after a binary image is created in the tools. These scripts are not really exportable, as they are part of the tools and may include and use any bits of python code they please. So we don't export them. This patch disables export combinations that would not work because the post-binary hook is not exported. A white-list is used for forward compatibility.
Nobody actually cares.
If the free memory on a device is small enough then the calculation to determine heap size could underflow to a large value. If this happens then malloc will never return failure and instead will cause a crash on allocation. This patch prevents the underflow so malloc works as expected even with low amounts of free memory.
The `sleep` function as been changed into `hal_sleep` by #3607. Unfortunately the call to `sleep` in the hal_patch for the NRF51822 has not been updated to `hal_sleep`. The result was a link time error for targets based on NRF51822_LEGACY compiling with the mbed OS 5 tree.
As done for other families, let's define the PWM channel in the PWM pins table definition rather than driver.
The pwmout driver is very similar for each STM32 family. The only family specific part is defined in pwmout_device.h file. It mainly contains few specific information: - The mapping of PWM/TIMERS to APB1 or APB2 so that we can get the clock - The clock calculation uses the right APB clock, which was sometimes not the case before and could have lead to errors in case dividers were enabled on APB clock settings. This case is now covered. - Inactivation of inverted support on feaw families
Correct the while loop limit and add a safe guard to avoid infinite loop.
In order to avoid possible multiple definitions errors, move the table initialization to the C file instead of header file
Use the recommended style
if (condition) {
do();
} else {
do_else();
}
Typo with misplaced closing parenthesis leads to compilation error, which is fixed with this patch
astyle done
… on the same pins + minor editorial corrections.
This is a bug fix for the following bug (Github issue #437): If two builds were run specifying a non-default build folder, the second build would fail to link with duplicate symbols and may not fit on the device. The root of this problem is that these non-default build folders are not ignored by scan-resources, and therefore included in the build. We fix this bug by ignoring the build directory passed into the tools.
The prior patch in this series makes the assumption that any building will go through `build_api.prepare_toolchain`. This was not a valid assumption for the mbed2 build process. So, instead of maintaining 2 ways of using the toolchain classes, I elected to unify on `prepare_toolchain`.
An earlier patch in this series relies on the assumption that all toolchain construction goes through `prepare_toolchain`. This is still not the case. The only remaining user of the `mbedToolchain` object that does not go through `prepare_toolchain` is the static analysis scanner. It's basically dead-code at this point. I say we remove it. So this patch removes it.
An earlier patch in this series changed the API for `build_api.prepare_toolchain`. This commit updates the `find_test` function to call `prepare_toolchain` correctly.
I accidentally broke only uARM mbed 2 builds. Here is the story: When scanning for resources, toolchains look for any `TOOLCHAIN_<classname>` folders to include. These `<classname>`s mostly match the name passed in on the command line with one exception: `uARM` on the command line maps to `ARM_MICRO` the class. This would not be a problem except for the bug that I introduced in a prior commit. The bug is that the mbed2 library builds will use the name passed in on the command line to construct `TOOLCHAIN_<cli-name>`. This will not match when scanning. I fixed it by translating the `<cli-name>` into the `<classname>`.
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
mbed-os-5.4.1 looks good. |
|
/morph mbed2-release |
Result: UNSTABLEYour command has finished executing! Here's what you wrote!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.