Add REALTEK_RTL8195AM to mbed-os #4438

0xc0170 · 2017-06-03T19:18:42Z

Rebased #3758

consistent with other tools

correct proprietary headers for some of our codes

also fix a minor building error

…tek/Lwipopts_conf.h to features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_Realtek/Lwipopts_conf.h

also reduce replicated code

also a minor fix to IAR icf file

correct heap size in icf file; improve REALTEK_RTL8195AM.py

right now still need to add flag in gcc.py, we are fixing!

see analogout_init()

(uvision, gcc_arm, iar)

should use space instead of tab

remove rtx and switch to rtx2

0xc0170 · 2017-06-03T19:19:10Z

There were no conflicts, so should be all the same !

0xc0170 · 2017-06-03T20:12:59Z

/morph test

mbed-bot · 2017-06-03T21:19:15Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 434

Build failed!

…TL8195AM There is an easy default implementation of spi_master_block_write that just calls spi_master_write in a loop, so the default implementation of spi_master_block_write has been added to all targets.

sg- · 2017-06-03T22:17:00Z

/morph test

mbed-bot · 2017-06-03T22:55:14Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 435

Build failed!

In class MBRBlockDevice the tole32 function had used union member names u32 and u8. The introduction of REALTEK_RTL8195AM cauesd a conflict with type names in basic_types given they're aliased as macros to uint32_t and uint8_t respectively.

sg- · 2017-06-03T23:16:56Z

/morph test

sg- · 2017-06-04T00:35:44Z

I think the proper fix to 1fa30b7 should have been:

diff --git a/targets/TARGET_Realtek/TARGET_AMEBA/sdk/soc/realtek/common/bsp/basic_types.h b/targets/TARGET_Realtek/TARGET_AMEBA/sdk/soc/realtek/common/bsp/basic_types.h
index 66f23546a..da881fcab 100644
--- a/targets/TARGET_Realtek/TARGET_AMEBA/sdk/soc/realtek/common/bsp/basic_types.h
+++ b/targets/TARGET_Realtek/TARGET_AMEBA/sdk/soc/realtek/common/bsp/basic_types.h
@@ -63,14 +63,14 @@ typedef signed long long        __int64_t;
 typedef unsigned long long      __uint64_t;
 #endif

-#define s8                      int8_t
-#define u8                      uint8_t
-#define s16                     int16_t
-#define u16                     uint16_t
-#define s32                     int32_t
-#define u32                     uint32_t
-#define s64                     int64_t
-#define u64                     uint64_t
+typedef int8_t s8;
+typedef uint8_t u8;
+typedef int16_t s16;
+typedef uint16_t u16;
+typedef int32_t s32;
+typedef uint32_t u32;
+typedef int64_t s64;
+typedef uint64_t u64;

 #ifdef CONFIG_MBED_ENABLED
 #ifndef BOOL

but I would like that change to come from Realtek in case the bsp/hal is copy paste from another release and wouldn't want a future regression.

mbed-bot · 2017-06-04T01:34:19Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 436

All builds and test passed!

Archcady · 2017-06-05T11:54:05Z

I think the fix is ok, we'll merge these changes back to our SDK. Thanks.

0xc0170 · 2017-06-05T12:20:00Z

@Archcady Please review #4439

Archcady added 30 commits June 3, 2017 20:14

Create mbed_rtx.h

bc948ca

Update targets.json

bbbecd7

add support for REALTEK_RTL8195AM

53e837b

Add lwipopts_conf.h

3d59643

Add rtl8195a_rom.so

04ede46

Rename rtl8195a_rom.so to rtl8195a_rom.o

c208094

improve coding style

9e9878f

consistent with other tools

change proprietary headers (APACHE2.0)

4d52f98

correct proprietary headers for some of our codes

Fix headers issue in TARGET_AMEBA\sdk\common folder

5e47ad0

py coding style

49baa97

update lib

3395ebc

update other file headers

c72257c

remove unused code

173315d

move network Interface API out

0d84a8d

remove useless definitions in device.h

41f20d6

also fix a minor building error

Remove IPV4 from features in targets.json

ad85a14

Rename features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/target_real…

d0488c1

…tek/Lwipopts_conf.h to features/FEATURE_LWIP/lwip-interface/lwip-eth/arch/TARGET_Realtek/Lwipopts_conf.h

complete postbuild process for IAR

0894548

also reduce replicated code

remove "default_build" from targets.json

3e9dafa

fix the issue that GCC builds extra-large bin file

b20d635

also a minor fix to IAR icf file

minor fixes

d75c5db

correct heap size in icf file; improve REALTEK_RTL8195AM.py

improve py code

9514cf8

Rename Lwipopts_conf.h to lwipopts_conf.h

6a47d01

WiFi test fix for GCC

7867a81

right now still need to add flag in gcc.py, we are fixing!

Fix postbuild for ARM & GCC

d461776

Mute RAM1 messages

f8019f4

mute debug message in RAM1 (changed)

9a0cb73

A fix to enum issue

02687b5

move REALTEK_RTL8195AM.py, remove progen in targets.json

29e11a1

Update lib (enum issue)

8d20c35

Archcady added 10 commits June 3, 2017 20:15

add comment for the delay in analogout_api.c

e289164

see analogout_init()

resolve RTWInterface initialization run after error issue

4eda93e

Add support for mbed exporter

92ca664

(uvision, gcc_arm, iar)

fix multiple i2c peripherals possible conflicting issue

c31d547

exporter coding style fix

88d4d1d

should use space instead of tab

Switch to rtx2

f71f578

remove rtx and switch to rtx2

remove unsupported device_name

7602d27

clean up GPL license with APACHE2.0

b76c8a9

fix icf file misspelling

fdea7b1

fix STRINGIFY redefining issue

3c3a9a6

0xc0170 mentioned this pull request Jun 3, 2017

Add REALTEK_RTL8195AM to mbed-os #3758

Closed

3 tasks

sg- added needs: CI release-version: 5.5.0-rc1 labels Jun 3, 2017

spi: Added default spi_master_block_write implementation to REALTEK_R…

be35b3f

…TL8195AM There is an easy default implementation of spi_master_block_write that just calls spi_master_write in a loop, so the default implementation of spi_master_block_write has been added to all targets.

Resolve conflict in builtin type names

1fa30b7

In class MBRBlockDevice the tole32 function had used union member names u32 and u8. The introduction of REALTEK_RTL8195AM cauesd a conflict with type names in basic_types given they're aliased as macros to uint32_t and uint8_t respectively.

sg- merged commit 273f653 into ARMmbed:master Jun 4, 2017

sg- removed the needs: CI label Jun 4, 2017

0xc0170 deleted the dev_realtek branch June 4, 2017 14:20

tung7970 mentioned this pull request Jun 5, 2017

lwip - fix typo and cleanup coding style #4441

Merged

malachib mentioned this pull request Jun 27, 2017

Adding RTL8711, RTL8710 #4643

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add REALTEK_RTL8195AM to mbed-os #4438

Add REALTEK_RTL8195AM to mbed-os #4438

0xc0170 commented Jun 3, 2017

0xc0170 commented Jun 3, 2017

0xc0170 commented Jun 3, 2017

mbed-bot commented Jun 3, 2017

sg- commented Jun 3, 2017

mbed-bot commented Jun 3, 2017

sg- commented Jun 3, 2017

sg- commented Jun 4, 2017

mbed-bot commented Jun 4, 2017

Archcady commented Jun 5, 2017

0xc0170 commented Jun 5, 2017

Add REALTEK_RTL8195AM to mbed-os #4438

Add REALTEK_RTL8195AM to mbed-os #4438

Conversation

0xc0170 commented Jun 3, 2017

0xc0170 commented Jun 3, 2017

0xc0170 commented Jun 3, 2017

mbed-bot commented Jun 3, 2017

Result: FAILURE

Output

sg- commented Jun 3, 2017

mbed-bot commented Jun 3, 2017

Result: FAILURE

Output

sg- commented Jun 3, 2017

sg- commented Jun 4, 2017

mbed-bot commented Jun 4, 2017

Result: SUCCESS

Output

Archcady commented Jun 5, 2017

0xc0170 commented Jun 5, 2017