Skip to content

Cellular: not-supported error if MODEM_ON_BOARD not defined #4672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2017
Merged

Cellular: not-supported error if MODEM_ON_BOARD not defined #4672

merged 1 commit into from
Jul 4, 2017

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jun 30, 2017 •
edited
Loading

If a test is empty, it leads to undef. Therefore if a test requires additional
details, it should print an error [NOT SUPPORTED].

This will require nighlty to verify.

This is the fix for the patch came from #4446

@hasnainvirk

0xc0170
0xc0170 commented Jun 30, 2017
View reviewed changes
features/netsocket/cellular/generic_modem_driver/TESTS/unit_tests/default/main.cpp Outdated
@@ -439,6 +439,8 @@ static void unlock()

#else

#error [NOT_SUPPORTED] MODEM_ON_BOARD should be set for this test to be functional
Copy link
Contributor Author

@0xc0170 0xc0170 Jun 30, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this can be even simplified, and print this error on the top of the file, this empty main is not required by our tools
@studavekar

@0xc0170
Cellular: not-supported error if MODEM_ON_BOARD not defined
334c02f 
If a test is empty, it leads to undef. Therefore if a test requires additional
details, it should print an error [NOT SUPPORTED].
@0xc0170 0xc0170 force-pushed the fix_cellular_test branch from 279b3da to 334c02f Compare June 30, 2017 09:01
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 30, 2017

I simplified the test, should be fine now, not report UNDEF

@0xc0170 0xc0170 mentioned this pull request Jun 30, 2017
Merged
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 30, 2017

/morph test-nightly

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 707

Test failed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jun 30, 2017

At least we can see now most of the jobs are green so fix is active !

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 2, 2017

/morph test-nightly

@mbed-bot
Copy link

mbed-bot commented Jul 3, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 718

Test failed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 3, 2017

/morph test-nightly

@0xc0170 0xc0170 mentioned this pull request Jul 3, 2017
Merged
@mbed-bot
Copy link

mbed-bot commented Jul 3, 2017

Result: ABORTED

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 720

Test failed!

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 3, 2017

Restarting (timeout in one host process)

/morph test-nightly

@mbed-bot
Copy link

mbed-bot commented Jul 3, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 721

Test failed!

@adbridge
Copy link
Contributor

adbridge commented Jul 3, 2017

K64F failed with

07:00:26 [1499083205.16][HTST][INF] host test class: '<class 'mbed_host_tests.host_tests.echo.EchoTest'>'
07:00:26 [1499083205.16][HTST][INF] host test setup() call...
07:00:26 [1499083205.16][HTST][INF] CALLBACKs updated
07:00:26 [1499083205.16][HTST][INF] host test detected: echo
07:00:27 [1499083205.72][CONN][RXD] :36::FAIL: Expected 16 Was 0

@adbridge
Copy link
Contributor

adbridge commented Jul 3, 2017

MAX32630FTHR failed with

06:40:27 mbedgt: mbed-host-test-runner: stopped and returned 'TIMEOUT'
06:40:27 mbedgt: test case summary event not found
06:40:27 	no test case report present, assuming test suite to be a single test case!
06:40:27 	test suite: features-frameworks-utest-tests-unit_tests-case_control_repeat
06:40:27 	test case: features-frameworks-utest-tests-unit_tests-case_control_repeat
06:40:27 mbedgt: test on hardware with target id: 04090000983f044e00000000000000000000000097969904
06:40:27 mbedgt: test suite 'features-frameworks-utest-tests-unit_tests-case_control_repeat' .................. TIMEOUT in 115.83 sec
06:40:27 	test case: 'features-frameworks-utest-tests-unit_tests-case_control_repeat' .................. ERROR in 115.83

There hasn't been any utest changes AFAIK so this looks like a transient CI issue

@studavekar
Copy link
Contributor

we need this change to run nightly on other PR

/morph test-nightly

@studavekar studavekar mentioned this pull request Jul 3, 2017
Merged
1 task
@mbed-bot
Copy link

mbed-bot commented Jul 4, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 724

All builds and test passed!

@0xc0170 0xc0170 merged commit ca1d913 into ARMmbed:master Jul 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-version: 5.5.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0xc0170 @mbed-bot @adbridge @studavekar