-
Notifications
You must be signed in to change notification settings - Fork 3k
Add Nuvoton m2351device #4892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nuvoton m2351device #4892
Conversation
Rebase time! |
0b53740
to
a09a9c8
Compare
0a39fa7
to
adb8ba4
Compare
@deepikabhavnani This is in need of another rebase. |
adb8ba4
to
490addf
Compare
Travis still is red |
490addf
to
e044d5b
Compare
Failure is CI is expected, as device patch is not yet added to IAR/uVision software |
so then remove the |
b1cdd7d
to
778e7c7
Compare
5827612
to
060fe56
Compare
Rebased and added support for ARMC6 compiler. Build for ARM fails with develop/release profile with ARMC6 compiler issue. Build works only for debug profile (optimization -o0) |
ARMC6 compiler support for Cortex device is moved to new PR #5094 |
@deepikabhavnani Did you mean specifically cortex-M23/33? I think all the devices are cortex. |
@theotherjimmy - Specific to Cortex-M23. Added that comment, because i will remove generic code from last commit (060fe56) which is for all cortex-m23 devices |
1dc6bc7
to
6eee56e
Compare
8e13f1d
to
508037e
Compare
It was named and used as if it were positive logic, and written with negative logic. This changes the name and usage to negative logic.
Commits for ARMC6 export are to verify ARMC6 and should be removed after branch from @theotherjimmy ( https://github.com/theotherjimmy/mbed/commits/uvision-armc6) is merged. |
I take it that you want me to push those commits up as a separate PR then! |
Serial init function is common for secure/non-secure serial devices, hence only the required secure function (CLK) should be set as secure. Gpio_dir() not required to be secure function since all GPIO ports are non-secure
@deepikabhavnani looks like this now needs a rebase.. |
@theotherjimmy @adbridge @0xc0170 - This PR is on hold till ARMC6 compiler issue is not resolved. |
Closing this, will reopen when work on this feature is resumed |
Rebased code from nuvoton_m2351_testchip_ref branch.
Status : In Development
Working on secure / non-secure separate binaries and way to access secure section from non-secure code.
Dependent on PR #5094
Rebase might be required after preceding PR's are merged.