Skip to content

Add Nuvoton m2351device #4892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

deepikabhavnani
Copy link

@deepikabhavnani deepikabhavnani commented Aug 11, 2017

Rebased code from nuvoton_m2351_testchip_ref branch.

Status : In Development
Working on secure / non-secure separate binaries and way to access secure section from non-secure code.
Dependent on PR #5094

Rebase might be required after preceding PR's are merged.

@theotherjimmy
Copy link
Contributor

Rebase time!

@theotherjimmy
Copy link
Contributor

@deepikabhavnani This is in need of another rebase.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 31, 2017

Travis still is red AssertionError: Target NUMAKER_PFM_M2351 contains invalid device_name M2351K1AAEES . However got like 3 dependencies, I believe this will get an update once those are merged

@deepikabhavnani
Copy link
Author

Failure is CI is expected, as device patch is not yet added to IAR/uVision software

@theotherjimmy
Copy link
Contributor

so then remove the device_has key.

@deepikabhavnani
Copy link
Author

Rebased and added support for ARMC6 compiler.

Build for ARM fails with develop/release profile with ARMC6 compiler issue. Build works only for debug profile (optimization -o0)

@deepikabhavnani
Copy link
Author

ARMC6 compiler support for Cortex device is moved to new PR #5094

@theotherjimmy
Copy link
Contributor

@deepikabhavnani Did you mean specifically cortex-M23/33? I think all the devices are cortex.

@deepikabhavnani
Copy link
Author

deepikabhavnani commented Sep 14, 2017

@theotherjimmy - Specific to Cortex-M23. Added that comment, because i will remove generic code from last commit (060fe56) which is for all cortex-m23 devices

@deepikabhavnani deepikabhavnani force-pushed the nuvoton_m2351_rebase branch 2 times, most recently from 1dc6bc7 to 6eee56e Compare September 14, 2017 19:18
@deepikabhavnani deepikabhavnani force-pushed the nuvoton_m2351_rebase branch 3 times, most recently from 8e13f1d to 508037e Compare October 16, 2017 15:18
@deepikabhavnani
Copy link
Author

deepikabhavnani commented Oct 17, 2017

Commits for ARMC6 export are to verify ARMC6 and should be removed after branch from @theotherjimmy ( https://github.com/theotherjimmy/mbed/commits/uvision-armc6) is merged.
List of commits - 67499b2 15e8d94 bed8a0b ea6212a 7005a67

@theotherjimmy
Copy link
Contributor

I take it that you want me to push those commits up as a separate PR then!

Serial init function is common for secure/non-secure serial devices, hence
only the required secure function (CLK) should be set as secure.

Gpio_dir() not required to be secure function since all GPIO ports are non-secure
@adbridge
Copy link
Contributor

@deepikabhavnani looks like this now needs a rebase..

@deepikabhavnani
Copy link
Author

@theotherjimmy @adbridge @0xc0170 - This PR is on hold till ARMC6 compiler issue is not resolved.
https://jira.arm.com/browse/SDCOMP-49132

@deepikabhavnani
Copy link
Author

Closing this, will reopen when work on this feature is resumed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants