malloc test refactoring #5323

maciejbocianski · 2017-10-16T14:04:32Z

Description

Test refactoring
Few test added: malloc(0), free(NULL), malloc(large size)

Status

READY

0xc0170 · 2017-10-17T11:49:53Z

c1728p9

This should be split into two separate PRs. One which adds the additional tests and the other which reduces test memory consumption.

bulislaw · 2017-10-17T22:04:03Z

Or at least commits

maciejbocianski · 2017-10-18T10:26:33Z

out of memory fix moved to #5338

0xc0170 · 2017-10-19T10:27:34Z

Update posted, please review

c1728p9 · 2017-10-19T19:37:30Z

TESTS/mbedmicro-rtos-mbed/malloc/main.cpp

+extern uint32_t mbed_heap_size;
+static const int test_timeout = 25;
+volatile bool thread_should_continue = true;
+#define NUM_THREADS 4


Did the number of threads need to be decreased to pass testing?

We could restore back thread count to 5, but it will cause fail on GCC_ARM.
To run 5 threads on GCC_ARM we have to free additional ~300B of heap memory.

To achieve this we could reduce thread allocation to 20B or move part of Thread objects on stack (but can not move all of them because we reach main thread stack limit).

Why do 5 threads no longer fit?

it turns out that refactoring (new test cases, functions, ...) increased static RAM usage by 480B as a result less memory remains for heap and fifth thread stack allocation fails

python tools/memap.py BUILD/tests/nucleo_f070rb/GCC_ARM/TESTS/mbedmicro-rtos-mbed/malloc/malloc.map -t GCC_ARM befor refactoring Total Static RAM memory (data + bss): 10172 bytes after refactoring Total Static RAM memory (data + bss): 10652 bytes diff Total Static RAM memory (data + bss): 480 bytes

extern uint32_t mbed_heap_size; printf("mbed_heap_size: %lu \r\n", mbed_heap_size); befor refactoring mbed_heap_size: 4996 after refactoring mbed_heap_size: 4516 diff mbed_heap_size: 480

adbridge · 2017-10-24T14:48:59Z

/morph build

mbed-ci · 2017-10-24T15:13:54Z

Build : FAILURE

Build number : 317
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5323/

studavekar · 2017-10-24T20:55:46Z

Looks git clone failure, Saw similar issue on few other PR as well

Receiving objects:  34% (11751/33717), 23.94 MiB | 39.00 KiB/s   
Receiving objects:  34% (11752/33717), 24.00 MiB | 41.00 KiB/s   
Receiving objects:  34% (11753/33717), 24.09 MiB | 46.00 KiB/s   
fatal: The remote end hung up unexpectedly
00:10:06.027 fatal: early EOF
00:10:06.027 fatal: index-pack failed
00:10:06.027 
00:10:06.027 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1924)
00:10:06.027 	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIIm

studavekar · 2017-10-24T20:55:54Z

/morph build

mbed-ci · 2017-10-24T21:47:52Z

Build : FAILURE

Build number : 324
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5323/

adbridge · 2017-10-26T11:06:44Z

/morph build

mbed-ci · 2017-10-26T11:32:11Z

Build : SUCCESS

Build number : 342
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5323/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-26T13:28:53Z

Test : FAILURE

Build number : 153
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5323/153

0xc0170 · 2017-10-26T14:06:01Z

@maciejbocianski NRF51_DK-IAR.tests-mbedmicro-rtos-mbed-malloc.Test multithreaded allocations failure in the last run - timeout with the error: [1509024079.73][CONN][RXD] Thread 0 error -11: Unknown

maciejbocianski · 2017-10-27T12:50:17Z

problem fixed - there was lack of thread stack alignment

0xc0170 · 2017-10-27T15:04:29Z

/morph build

mbed-ci · 2017-10-27T15:28:26Z

Build : SUCCESS

Build number : 354
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5323/

Triggering tests

/morph test
/morph uvisor-test

0xc0170 · 2017-11-15T09:16:16Z

@maciejbocianski Looking at the commits here. Bad rebase? As I see here changes that went to master previously, and not related to this patch. Please review

maciejbocianski · 2017-11-15T10:06:24Z

@0xc0170 done

0xc0170 · 2017-11-15T10:57:03Z

/morph build

mbed-ci · 2017-11-15T12:09:32Z

Build : SUCCESS

Build number : 524
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5323/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2017-11-15T13:57:05Z

Exporter Build : SUCCESS

Build number : 138
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5323/

mbed-ci · 2017-11-15T15:25:59Z

Test : SUCCESS

Build number : 328
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5323/328

0xc0170 · 2017-11-16T12:50:15Z

Manually triggered CI uvisor job, should complete soon. This is the last CI that needs t o be completed for this patch.

Once done, ready for integration

0xc0170 · 2017-11-16T14:20:16Z

@studavekar Waiting for nucleo_f070rb run

0xc0170 · 2017-11-16T16:08:17Z

@studavekar Waiting for nucleo_f070rb run

@maciejbocianski As you asked about that nucleo, I could not identify any test run for this device, is that correct?

maciejbocianski · 2017-11-17T09:37:15Z

@studavekar @0xc0170
My fault, I fancied that nucleo_f070rb was connected to CI earlier but wasn't
BTW are we plan to add more devices to CI, especially devices with small RAM (<= 16kB)

theotherjimmy · 2017-11-20T16:49:27Z

/morph uvisor-test

0xc0170 · 2017-11-22T13:55:52Z

uvisor restarted, jenkins exception in the job

adbridge added the needs: review label Oct 16, 2017

maciejbocianski force-pushed the malloc_tests branch 3 times, most recently from 8f8b29b to 970e39e Compare October 17, 2017 08:23

c1728p9 suggested changes Oct 17, 2017

View reviewed changes

maciejbocianski force-pushed the malloc_tests branch from 970e39e to df3cd4f Compare October 18, 2017 12:33

maciejbocianski force-pushed the malloc_tests branch from df3cd4f to ec34ba4 Compare October 19, 2017 12:26

c1728p9 reviewed Oct 19, 2017

View reviewed changes

c1728p9 approved these changes Oct 19, 2017

View reviewed changes

theotherjimmy added needs: CI and removed needs: review labels Oct 23, 2017

0xc0170 added needs: work and removed needs: CI labels Oct 26, 2017

maciejbocianski force-pushed the malloc_tests branch from ec34ba4 to 751fa15 Compare October 27, 2017 12:50

maciejbocianski force-pushed the malloc_tests branch from 28d201c to b2e0788 Compare November 15, 2017 09:56

malloc test refactoring

a7f31c9

maciejbocianski force-pushed the malloc_tests branch from b2e0788 to a7f31c9 Compare November 15, 2017 10:04

0xc0170 added needs: CI and removed needs: work labels Nov 15, 2017

0xc0170 added ready for merge needs: CI and removed needs: CI ready for merge labels Nov 16, 2017

0xc0170 added ready for merge and removed needs: CI labels Nov 20, 2017

theotherjimmy added needs: CI and removed ready for merge labels Nov 20, 2017

theotherjimmy added ready for merge release-version: 5.6.6 and removed needs: CI labels Nov 22, 2017

theotherjimmy merged commit 308833b into ARMmbed:master Nov 22, 2017

theotherjimmy removed the ready for merge label Nov 22, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

malloc test refactoring #5323

malloc test refactoring #5323

maciejbocianski commented Oct 16, 2017 •

edited

Loading

0xc0170 commented Oct 17, 2017

c1728p9 left a comment

bulislaw commented Oct 17, 2017

maciejbocianski commented Oct 18, 2017

0xc0170 commented Oct 19, 2017

c1728p9 Oct 19, 2017

maciejbocianski Oct 19, 2017 •

edited

Loading

c1728p9 Oct 24, 2017

maciejbocianski Oct 25, 2017 •

edited

Loading

adbridge commented Oct 24, 2017

mbed-ci commented Oct 24, 2017

studavekar commented Oct 24, 2017

studavekar commented Oct 24, 2017

mbed-ci commented Oct 24, 2017

adbridge commented Oct 26, 2017

mbed-ci commented Oct 26, 2017

mbed-ci commented Oct 26, 2017

0xc0170 commented Oct 26, 2017

maciejbocianski commented Oct 27, 2017

0xc0170 commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

0xc0170 commented Nov 15, 2017

maciejbocianski commented Nov 15, 2017

0xc0170 commented Nov 15, 2017

mbed-ci commented Nov 15, 2017

mbed-ci commented Nov 15, 2017

mbed-ci commented Nov 15, 2017

0xc0170 commented Nov 16, 2017

0xc0170 commented Nov 16, 2017

0xc0170 commented Nov 16, 2017

maciejbocianski commented Nov 17, 2017 •

edited

Loading

theotherjimmy commented Nov 20, 2017

0xc0170 commented Nov 22, 2017

malloc test refactoring #5323

malloc test refactoring #5323

Conversation

maciejbocianski commented Oct 16, 2017 • edited Loading

Description

Status

0xc0170 commented Oct 17, 2017

c1728p9 left a comment

Choose a reason for hiding this comment

bulislaw commented Oct 17, 2017

maciejbocianski commented Oct 18, 2017

0xc0170 commented Oct 19, 2017

Choose a reason for hiding this comment

maciejbocianski Oct 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maciejbocianski Oct 25, 2017 • edited Loading

Choose a reason for hiding this comment

adbridge commented Oct 24, 2017

mbed-ci commented Oct 24, 2017

studavekar commented Oct 24, 2017

studavekar commented Oct 24, 2017

mbed-ci commented Oct 24, 2017

adbridge commented Oct 26, 2017

mbed-ci commented Oct 26, 2017

Triggering tests

mbed-ci commented Oct 26, 2017

0xc0170 commented Oct 26, 2017

maciejbocianski commented Oct 27, 2017

0xc0170 commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

Triggering tests

0xc0170 commented Nov 15, 2017

maciejbocianski commented Nov 15, 2017

0xc0170 commented Nov 15, 2017

mbed-ci commented Nov 15, 2017

Triggering tests

mbed-ci commented Nov 15, 2017

mbed-ci commented Nov 15, 2017

0xc0170 commented Nov 16, 2017

0xc0170 commented Nov 16, 2017

0xc0170 commented Nov 16, 2017

maciejbocianski commented Nov 17, 2017 • edited Loading

theotherjimmy commented Nov 20, 2017

0xc0170 commented Nov 22, 2017

maciejbocianski commented Oct 16, 2017 •

edited

Loading

maciejbocianski Oct 19, 2017 •

edited

Loading

maciejbocianski Oct 25, 2017 •

edited

Loading

maciejbocianski commented Nov 17, 2017 •

edited

Loading