Fixes NUCLEO_F746ZG gethostbyname test compiled with IAR

[jarlamsa]

Description

Fixes intermittently failing gethostbyname test on NUCLEO_F746ZG compiled with IAR

Status

READY

[jeromecoutant]

Hi
Please check #5576
I would like to be able to define this host name with MBED app json file.
Thx

[kjbracey]

So, what gave the idea for the change? Is it just aligning it with other tests?

Is it maybe the case that MBED_DNS_TEST_HOST was defined to something different, so you've changed what we're resolving?

Or is it actually about those global variables you've just hidden by putting into a private namespace? Were they colliding with something?

[kjbracey]

Actually, didn't we establish that this was failing in the connect before doing the gethostbyname? Which would suggest it is those global variables.

Don't suppose the build muttered anything about multiple definition on the link, did it?

[jarlamsa]

socket_sigio has similar setup than this test, so I started by aligning with that one, since it wasn't failing. I actually tested that the MBED_DNS_TEST_HOSTwas the one that caused this, changing it to const char * fixed the issue, but according to @jeromecoutant this actually doesn't allow user to change the host from MBED app json.

The private namespace I added there for safety precaution, like it has been done with other tests.

[kjbracey]

Do you know whether MBED_DNS_TEST_HOST was predefined or not when failing? That choice of mbed.connector.com was in an ifndef.

[jarlamsa]

Didn't at least see any definitions for it anywhere.

[jeromecoutant]

Note that #5576 is now merged,
so maybe issue #5622 will be closed by @0xc0170 or @kegilbert

[0xc0170]

@jarlamsa Can you rebase this to get the latest changes ? Is this patch still needed?

[kjbracey]

This should be closed - it's not a real fix. We'll carry on investigating in #5622