-
Notifications
You must be signed in to change notification settings - Fork 3k
Increase clock tolerance in Flash HAL test #5831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The current 0.1% clock tolerance is too small for certain platforms which natural variance is larger than this. This commit increases the tolerance to 0.5% instead. Sample output from time_cpu_cycles called repeatedly in init, before running any flash tests: [1515706585.63][CONN][RXD] diff: 49316 [1515706585.69][CONN][RXD] diff: 49256 [1515706585.75][CONN][RXD] diff: 49286 [1515706585.81][CONN][RXD] diff: 49256 [1515706585.87][CONN][RXD] diff: 49225 [1515706585.94][CONN][RXD] diff: 49286 [1515706585.99][CONN][RXD] diff: 49317 [1515706586.06][CONN][RXD] diff: 49255 [1515706586.12][CONN][RXD] diff: 49286 [1515706586.18][CONN][RXD] diff: 49285 [1515706586.24][CONN][RXD] diff: 49286 [1515706586.31][CONN][RXD] diff: 49347 [1515706586.36][CONN][RXD] diff: 49347 [1515706586.43][CONN][RXD] diff: 49286 [1515706586.49][CONN][RXD] diff: 49286 [1515706586.55][CONN][RXD] diff: 49256 [1515706586.61][CONN][RXD] diff: 49286 [1515706586.68][CONN][RXD] diff: 49346 [1515706586.74][CONN][RXD] diff: 49347 [1515706586.80][CONN][RXD] diff: 49256 Notice the outliers will cause intermittent CI failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for investigating this @marcuschangarm
@studavekar we need this PR before adding the NRF52840_DK to the test farm. |
/morph build |
Build : SUCCESSBuild number : 844 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 512 |
Test : SUCCESSBuild number : 688 |
Thanks Marcus for the PR, CI looks green and is ready for merge |
Description
The current 0.1% clock tolerance is too small for certain platforms
which natural variance is larger than this. This commit increases the
tolerance to 0.5% instead.
Sample output from time_cpu_cycles called repeatedly in init,
before running any flash tests:
[1515706585.63][CONN][RXD] diff: 49316
[1515706585.69][CONN][RXD] diff: 49256
[1515706585.75][CONN][RXD] diff: 49286
[1515706585.81][CONN][RXD] diff: 49256
[1515706585.87][CONN][RXD] diff: 49225
[1515706585.94][CONN][RXD] diff: 49286
[1515706585.99][CONN][RXD] diff: 49317
[1515706586.06][CONN][RXD] diff: 49255
[1515706586.12][CONN][RXD] diff: 49286
[1515706586.18][CONN][RXD] diff: 49285
[1515706586.24][CONN][RXD] diff: 49286
[1515706586.31][CONN][RXD] diff: 49347
[1515706586.36][CONN][RXD] diff: 49347
[1515706586.43][CONN][RXD] diff: 49286
[1515706586.49][CONN][RXD] diff: 49286
[1515706586.55][CONN][RXD] diff: 49256
[1515706586.61][CONN][RXD] diff: 49286
[1515706586.68][CONN][RXD] diff: 49346
[1515706586.74][CONN][RXD] diff: 49347
[1515706586.80][CONN][RXD] diff: 49256
Notice the outliers will cause intermittent CI failures.