Skip to content

Netbeans Exporter Bugfix #5901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmonr merged 2 commits into from
Jan 29, 2018
Merged

Netbeans Exporter Bugfix #5901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bb35ca
Fixed a bug with multiple Sub-Directories with same name
Jan 23, 2018
1ea22c1
Updated List comparision with shorter implementaion using python buil…
Jan 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tools/export/nb/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,9 +325,11 @@ def get_netbeans_file_list(file_list):
if cur_dir and prev_dir != cur_dir:
# evaluate all matched items (from current and previous list)
matched = []
for element in dir_list:
if element in prev_dir_list:
matched.append(element)
# Compare the Element in Previous Dir with the Elements in Current Dir
# and add the equal Elements to the match-List
for elem_prev_dir, elem_cur_dir in zip(prev_dir_list, dir_list):
if elem_prev_dir == elem_cur_dir:
matched.append(elem_cur_dir)
Copy link
Contributor

@theotherjimmy theotherjimmy Jan 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The use of elem in these variable names dose not add any meaning for me. I would like to seem them removed, but I won't block this PR for it.

Copy link
Author

@cmens23 cmens23 Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I remove the prefix elem it will not work as expected, because the variables prev_dir and cur_dir are already defined in scope.

Copy link
Contributor

@theotherjimmy theotherjimmy Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's part of why I would like another name: the current name is almost a name clash. Like I said, not blocking just a wish. Let me know if you come up with something.


# calculate difference between matched and length
diff = dir_depth - len(matched)
Expand Down