Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RZ/A1H] mbed-RZ first release #594

Merged
merged 36 commits into from
Nov 6, 2014
Merged

[RZ/A1H] mbed-RZ first release #594

merged 36 commits into from
Nov 6, 2014

Conversation

tkuro-rel
Copy link
Contributor

including

  • mbed cmsis for RZ/A1H
  • mbed hal for RZ/A1H
    • GPIO, Timer, I2C, SPI, InterruptIn
  • CA9 related files
  • RTOS support files for RZ/A1H

including
- mbed cmsis  for RZ/A1H
- mbed hal    for RZ/A1H
 - GPIO, Timer, I2C, SPI, InterruptIn
- CA9 related files
- RTOS support files for RZ/A1H
@bogdanm
Copy link
Contributor

bogdanm commented Oct 23, 2014

Hello,

Thanks for your pull request. There is a single, very large commit in this pull request, which prevents github from displaying it completely, which, in turn, prevents us from adding the proper comments. Could you please split it into multiple, smaller commits? For example:

  • one commit for build system changes
  • one commit for RTOS changes
  • one commit for HAL changes
  • one commit for CMSIS changes

This is just a suggestion, your commits can be even smaller than this and can follow a different structure.

Thanks,
Bogdan

@tkuro-rel
Copy link
Contributor Author

Hello,
Thank you for suggestions.
The original branch is split more finely. I feel suggested level seems nice. I will split and organize commit tomorrow.

Regards,
Kurosawa

- add CA9 category to build.py
- add library for RTX-CA9
- add target definition for RZ/A1H
- change some test related settings for RZ/A1H
- add gcc options for CA9
- adds CA9 related headers
- adds start up routine (only ARMCC is supported)
- adds scatter file for RZ/A1H
- adds GIC driver
- adds peripheral definitions(iodefine) for RZ/A1H
- adds serial flash boot loader for RZ/A1H
- adds GPIO driver
- adds I2C driver
- adds SPI driver
- adds PWM driver
- adds serial driver (irq not supported)
- adds ticker driver
- add analogin driver
- adds RTX-CA related files
- changes Thread.cpp for CA9
- adds GR-PEACH entry to README.md
There was two sections for sflash which lead to
separate output .bin file. Fixed.
RZ/A1H has GIC instead of NVIC. InterruptManger assumes
NVIC only, so temporarily ifdef guarded in order to pass
the compilation.
@tkuro-rel
Copy link
Contributor Author

I split commits to 4 levels and fixed some bugs, and added description for GR-PEACH in README.md.
Could you please check commits and merge them if there's no problem.

@tkuro-rel
Copy link
Contributor Author

there're some changes after this pull-request.
Is it better to close this Pull-request once? Or continue anyway?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2014

You can push commits if you consider there should be part of this pull request.
Please share with us if there's still a development ongoing, otherwise it's considered to be feature completed and available for review/merge/test.

@tkuro-rel
Copy link
Contributor Author

These USB related commits are the last. it's considered to be feature completed and available for review/merge/test. thank you very much in advance.

@bogdanm
Copy link
Contributor

bogdanm commented Oct 24, 2014

This does not compile for me using GNU ARM embedded with gcc 4.7.4, I get loads of error in mmu_Renesas_RZ_A1.c. To reproduce:

workspace_tools\build.py -t GCC_ARM -m RZ_A1H

@tkuro-rel
Copy link
Contributor Author

Hello, bogdanm-san,

GCC is not currently supported. So I reverted gcc related .py files.
I'm sorry for confusion by my mistake.

Regard,
Kurosawa

Although the Ethernet functionality is not for review.
@masaohamanaka-zz
Copy link

Hello

I posted Ethernet related commits.
Although the Ethernet functionality is not for review.

Regard,
Hamanaka

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2014

Hi,

thanks. Why did you decide to add Ethernet if there's a message: not for review ? If it's not feature complete, it should be on the separate branch and push to a master once "ready for review and functional".

Regards,
0xc0170

@masaohamanaka-zz
Copy link

Hi, 0xc0170-san

Function of Ethernet is complete.
There will be a event for early beta testers and we must include the Ethernet functionality.
So, I decided to include to this request.

Regards,
Hamanaka

@bogdanm
Copy link
Contributor

bogdanm commented Nov 3, 2014

The USB stack does not compile for me:

workspace_tools\build.py -t ARM -m RZ_A1H -u
Building library CMSIS (RZ_A1H, ARM)
Building library MBED (RZ_A1H, ARM)
Building library USBDEVICE (RZ_A1H, ARM)
Compile: USBAudio.cpp
[Error] iodefine.h@97: #5: cannot open source input file "iodefines/adc_iodefine.h": No such file or directory
"no source": Warning: #3036-D: "c:/software/armcc5.03.117\include" was specified as both a system and non-system include directory -- the non-system entry will be ignored
"c:/work/mbed/build\mbed\TARGET_RZ_A1H/iodefine.h", line 97: Error: #5: cannot open source input file "iodefines/adc_iodefine.h": No such file or directory
C:\work\mbed\github-new\libraries\USBDevice\USBAudio\USBAudio.cpp: 1 warning, 1 error

Completed in: (0.33)s

Build failures:

  • ARM::RZ_A1H

AMANUMA Kazuhisa and others added 9 commits November 5, 2014 14:25
…on moved into USBHAL_RZA1H.cpp. * Interrupts registration routine returned to the original sample code.
RZ's toolchain assumes that iodefines/iobitmasks dirs. are structured real not flat.
Adds some code to toolchain::copy_files
RZ's toolchain assumes that iodefines/iobitmasks dirs. are structured real not flat.
Adds some code to toolchain::copy_files
- some topics
 - subsub toppics
AMANUMA Kazuhisa and others added 5 commits November 6, 2014 10:14
…in USBHAL.h moved into USBHAL_RZ_A1H.cpp. * Some functions writing by c++ changed to macro function.
Fixed copyright and correction of erroneous description.
Conflicts:
	workspace_tools/targets.py
@tkuro-rel
Copy link
Contributor Author

Hello, bogdanm-san

The USB stack does not compile for me:

Now USB lib can be (hopefully) compiled. Could you ,please try it again?

@bogdanm
Copy link
Contributor

bogdanm commented Nov 6, 2014

Hello,

There are still some things to fix (mainly in the build system), but the pull request looks good enough for merging now (and the USB library compiles fine).. Thanks for addressing my comments.

Bogdan

bogdanm added a commit that referenced this pull request Nov 6, 2014
[RZ/A1H] mbed-RZ first release
@bogdanm bogdanm merged commit 8724eb6 into ARMmbed:master Nov 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants