Skip to content

[feature-nrf528xx] Fix TRNG for NRF52 #6128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2018
Merged

[feature-nrf528xx] Fix TRNG for NRF52 #6128

merged 1 commit into from
Feb 21, 2018

Conversation

marcuschangarm
Copy link
Contributor

When multiple TRNG objects are initialized, destroying the first
object will turn the TRNG off for the other objects.

This fix adds a counter to ensure that only when the last object
is destroyed will it cause the TRNG to be disabled.

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 19, 2018

How is this different from #6116 ?

@marcuschangarm
Copy link
Contributor Author

This uses the new driver in SDK 14.2 which works whether the SoftDevice is enabled or not. In #6116 a different path is taken if the SoftDevice is not enabled or not present.

@0xc0170 0xc0170 requested a review from pan- February 21, 2018 14:24
@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

@pan- Can you help to review this patch?

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 21, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1203
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6128/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

When multiple TRNG objects are initialized, destroying the first
object will turn the TRNG off for the other objects.

This fix adds a counter to ensure that only when the last object
is destroyed will it cause the TRNG to be disabled.
@studavekar
Copy link
Contributor

new changes were added since last build

/morph build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

Build : SUCCESS

Build number : 1206
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6128/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@mbed-ci
Copy link

mbed-ci commented Feb 21, 2018

@cmonr cmonr merged commit a6dba4d into ARMmbed:feature-nrf528xx Feb 21, 2018
@marcuschangarm marcuschangarm deleted the fix_trng branch March 6, 2018 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants