Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAR: Fixed #6670 #6752

Closed
wants to merge 1 commit into from
Closed

IAR: Fixed #6670 #6752

wants to merge 1 commit into from

Conversation

TTornblom
Copy link
Contributor

Description

This fix implements preprocessing of assembler files similar to the ARM toolchain.

The fix has been tested on the mbed-os-example-blinky example, with the same configuration
changes as described in #6670.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@theotherjimmy
Copy link
Contributor

@TTornblom How does this export?

@TTornblom
Copy link
Contributor Author

As far as I know this is only related to building, not exporting.

It adds an intermediate preprocessor step for assembler files, similar to what is used for the ARM toolchain. Parts of the change was pulled from the arm.py file.

@TTornblom
Copy link
Contributor Author

I can't check why the continuous-integration/jenkins/pr-head failed as the details appears to be on an internal system. Can anyone provide the details?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2018

I can't check why the continuous-integration/jenkins/pr-head failed as the details appears to be on an internal system. Can anyone provide the details?

We will look at this and report back

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 26, 2018

Restarted jenkins CI, failure to report back status to github

@theotherjimmy
Copy link
Contributor

theotherjimmy commented Apr 26, 2018

As far as I know this is only related to building, not exporting.

The exporters must mimic what the build system does, so any changes to build system behaviors must come with an exporter update. This changes something in building, so it mush come with a change to exporting to match it.

It adds an intermediate preprocessor step for assembler files, similar to what is used for the ARM toolchain.

If a user were to use this new behavior in mbed compile they would be stumped if it did not work correctly when exporting. Could you update the iar based exporters (IAR and make_iar, last I checked) to implement the same feature?

Edit: tone.

Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add similar functionality to the IAR based exporters.

@ashok-rao
Copy link
Contributor

@TTornblom , are you OK to address the comments above? Thanks!

@TTornblom
Copy link
Contributor Author

Will rework this, closing PR

@TTornblom TTornblom closed this Apr 30, 2018
@sg- sg- removed the needs: work label Apr 30, 2018
@TTornblom TTornblom reopened this May 2, 2018
@TTornblom TTornblom closed this May 2, 2018
@TTornblom
Copy link
Contributor Author

Resubmitting. Will also submit a doc PR describing what needs to be done when exporting to IAR Embedded Workbench

@TTornblom TTornblom reopened this May 24, 2018
@TTornblom
Copy link
Contributor Author

A new paragraph has been added to https://github.com/TTornblom/Handbook/blob/new_engine/docs/tools/toolchains/export_to_third_party.md to address the issues with exporting to IAR Embedded Workbench

@TTornblom
Copy link
Contributor Author

Reworking this to fix exporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants