Skip to content

Use RTOS wait primitive where possible #6969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Use RTOS wait primitive where possible #6969

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d7f371
For millisecond and above precision, use an RTOS wait since task swit…
stevew817 May 21, 2018
7988698
Guard Thread::wait from being called in a critical section
stevew817 May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions platform/mbed_wait_api_rtos.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,18 @@
#include "platform/mbed_power_mgmt.h"

void wait(float s) {
wait_us(s * 1000000.0f);
wait_ms(s * 1000.0f);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks the interface of wait(float s) as you can no longer wait sub ms time deltas

}

void wait_ms(int ms) {
wait_us(ms * 1000);
// Shouldn't be calling a wait function from a critical section,
// but in case someone does...
if (core_util_are_interrupts_enabled()) {
Copy link

@felix-ht felix-ht May 22, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait_us calls thread::wait (no busy wait), if the input is a multiple of 1000, which it is if the input is in milliseconds. So the behavior of your implementation is the same as in the current one besides that you are not surrounding it with sleep_manager_lock_deep_sleep - sleep_manager_unlock_deep_sleep.

Thread::wait((uint32_t)ms);
} else {
wait_us(ms * 1000);
}

}

void wait_us(int us) {
Expand Down