Bring in improved HAL APIs to master #7009

bulislaw · 2018-05-24T20:14:01Z

Description

This one PR to rule them all (tm) combines:
#6996
#6995
#6994

@ARMmbed/mbed-os-maintainers

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

bulislaw · 2018-05-25T04:30:19Z

@ARMmbed/mbed-os-maintainers please run ci.
@ithinuel @jamesbeyond @0xc0170 could you keep an eye on that and try to fix it if somethings goes wrong.

0xc0170 · 2018-05-25T07:07:16Z

/morph build

0xc0170

What are the coverage numbers for these features (how much target coverage percentage ?) ?

mbed-ci · 2018-05-25T08:05:14Z

Build : FAILURE

Build number : 2147
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7009/

0xc0170 · 2018-05-25T08:21:33Z

Reviewing build failures now

0xc0170 · 2018-05-25T08:52:45Z

Resolved both errors, tested locally , should build now and all be good 🤞

/morph build

mbed-ci · 2018-05-25T10:49:51Z

Build : FAILURE

Build number : 2149
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7009/

0xc0170 · 2018-05-25T11:10:32Z

One error missed (gcc somehow passed 😕 ), restarting

/morph build

ithinuel

This PR is pretty big so I'll slip my reviews so I don't loose pending comments.

ithinuel · 2018-05-25T11:58:26Z

TESTS/mbed_drivers/lp_timer/main.cpp

+ *  */
+#define DELTA_US(delay_ms) (500 + delay_ms * US_PER_MSEC / 20)
+#define DELTA_MS(delay_ms) (1 + (delay_ms * US_PER_MSEC / 20 / US_PER_MSEC))
+#define DELTA_S(delay_ms) (0.000500f + (((float)delay_ms) / MSEC_PER_SEC / 20))


As macro in C (and c++) are basic text subtitution, it is usually good practice to wrap the macro's argument between brackets.
If you pass to DELTA_US an expression such as a_var + something_else you may not obtain what you expect.

#define DELTA_US(delay_ms) (500 + (delay_ms) * US_PER_MSEC / 20)

Also, as this is in test it does not really impact the final code but in debug mode, double division may not get optimised away and (1 + (delay_ms * US_PER_MSEC / 20 / US_PER_MSEC)) will try to run 2 divisions.

From what I see on GH these three macros are defined twice (the other definitions are line 63).

And worse than that they are actually defined differently!!

Nice catch. I agree with the first part, but since arithmetic operations are not passed to the macro its not a critical error.
Unfortunately the second bug is unsafe. It looks like I forgot to remove old definitions 😢 .

Can you add a commit fixing this?

@bulislaw needs to add you as collaborator to his repo.

I can help, got that branch locally, point me to a commit and I'll cherry pick and push

Fix can be found here:
mprse@83a0146

Tested on NRF51_DK, NRF52_DK boards and GCC_ARM.

@mprse actually there are arithmetic in mbed_drivers/timer/main.cpp#L724
It is ok as it is just division but for maintainability it might create non-obvious bugs.

Provided fix adds brackets.

mbed-ci · 2018-05-25T12:19:11Z

Build : SUCCESS

Build number : 2150
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7009/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

adbridge · 2018-05-25T12:35:13Z

TESTS/mbed_drivers/lp_timer/main.cpp

+ *  */
+#define DELTA_US(delay_ms) (500 + delay_ms * US_PER_MSEC / 20)
+#define DELTA_MS(delay_ms) (1 + (delay_ms * US_PER_MSEC / 20 / US_PER_MSEC))
+#define DELTA_S(delay_ms) (0.000500f + (((float)delay_ms) / MSEC_PER_SEC / 20))


And worse than that they are actually defined differently!!

mbed-ci · 2018-05-25T13:55:22Z

Test : FAILURE

Build number : 1943
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7009/1943

mprse · 2018-05-25T14:01:16Z

I have noticed that there is some inconsistency on this branch DEVICE_LOWPOWERTIMER should be replaced with DEVICE_LPTICKER in all source files and tests.

mprse · 2018-05-25T14:17:04Z

tests-mbed_hal-rtc_reset has failed on NRF52_DK board (all compilers), but as far as I remember RTC support should be disabled for this board (since it can not persist time over the reset).

cmonr · 2018-05-27T23:50:27Z

@0xc0170 Sorry, but to mention that Deepika came online and merged those two PRs, unblocking this one.

mbed-ci · 2018-05-28T00:17:50Z

Build : SUCCESS

Build number : 2171
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7009/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-28T01:36:11Z

Exporter Build : SUCCESS

Build number : 1795
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7009/

mbed-ci · 2018-05-28T01:38:33Z

Test : FAILURE

Build number : 1959
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7009/1959

bulislaw · 2018-05-28T04:32:39Z

/morph build

mbed-ci · 2018-05-28T05:32:05Z

Build : SUCCESS

Build number : 2172
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7009/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mprse · 2018-05-28T06:18:47Z

Looking into the sleep issue.

mbed-ci · 2018-05-28T06:51:54Z

Test : SUCCESS

Build number : 1960
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7009/1960

mbed-ci · 2018-05-28T07:35:39Z

Exporter Build : SUCCESS

Build number : 1796
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7009/

0xc0170 · 2018-05-28T08:32:05Z

@ithinuel Were your comments addressed ? If not, are they blocking ?

ithinuel · 2018-05-28T08:53:19Z

@0xc0170 One is awaiting an answer from @SenRamakri but I don't think they are blocking
Do you need me to change the review's status ?

ithinuel

The documentation related comments can be addressed later.

mprse · 2018-05-28T09:16:24Z

Fix for http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7009/1959/FAIL/NRF51_DK/ can be found here:

mprse@eeab68d

cmonr added needs: review release-version: 5.9.0-rc1 labels May 24, 2018

This was referenced May 24, 2018

Merge feature-hal-spec-ticker to master #6995

Closed

Merge feature-hal-spec-sleep to master #6994

Closed

Merge feature-hal-spec-rtc to master #6996

Closed

0xc0170 requested a review from a team May 25, 2018 07:55

0xc0170 previously approved these changes May 25, 2018

View reviewed changes

0xc0170 dismissed their stale review via 3b1f2ec May 25, 2018 08:52

0xc0170 mentioned this pull request May 25, 2018

Add Hardware CRC HAL API specification #6708

Merged

0xc0170 added needs: CI and removed needs: review labels May 25, 2018

adbridge added the risk: A label May 25, 2018

ithinuel suggested changes May 25, 2018

View reviewed changes

adbridge added needs: work and removed needs: CI labels May 25, 2018

adbridge self-requested a review May 25, 2018 12:37

adbridge previously requested changes May 25, 2018

View reviewed changes

adbridge added risk: R and removed risk: A labels May 25, 2018

bulislaw added 5 commits May 27, 2018 23:31

Disable RTC on MAX32630FTHR due to failing tests

1224b38

Disable intermittently failing sleep test

817bf0b

Disable FLASH for AD boards as they fail the tests intermittently

dc6ad34

Disable FLASH algo for AD boards

a1ff22d

Disable sleep tests as they are unstable

4ae6491

bulislaw force-pushed the merge_feature_branches_for_5.9 branch from 78eb673 to 4ae6491 Compare May 28, 2018 04:31

0xc0170 approved these changes May 28, 2018

View reviewed changes

ithinuel approved these changes May 28, 2018

View reviewed changes

0xc0170 added ready for merge and removed needs: work labels May 28, 2018

0xc0170 merged commit 501a7b6 into ARMmbed:master May 28, 2018

kjbracey mentioned this pull request May 28, 2018

Fix lwIP PPP glue #7030

Merged

cmonr removed risk: R ready for merge labels Jun 7, 2018

jamesbeyond mentioned this pull request Jun 8, 2018

Enable new HAL us_ticker API on fast model MPS2 platform #7175

Merged

jeromecoutant mentioned this pull request Jul 2, 2018

Heap issue on DISCO_L475VG_IOT01A with simple threading example #7379

Closed

jamesbeyond mentioned this pull request Sep 25, 2018

UBLOX_EVK_ODIN_W2 target failed on mbed HAL lp_ticker/sleep/rtc greentea test #8196

Closed

amq mentioned this pull request Feb 5, 2020

EFM32: RTC test fails #12374

Closed

Bring in improved HAL APIs to master #7009

Bring in improved HAL APIs to master #7009

Conversation

bulislaw commented May 24, 2018

Description

Pull request type

bulislaw commented May 25, 2018 • edited Loading

0xc0170 commented May 25, 2018

0xc0170 left a comment

Choose a reason for hiding this comment

mbed-ci commented May 25, 2018

0xc0170 commented May 25, 2018

0xc0170 commented May 25, 2018

mbed-ci commented May 25, 2018

0xc0170 commented May 25, 2018

ithinuel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbed-ci commented May 25, 2018

Triggering tests

Choose a reason for hiding this comment

mbed-ci commented May 25, 2018

mprse commented May 25, 2018 • edited Loading

mprse commented May 25, 2018 • edited Loading

cmonr commented May 27, 2018

mbed-ci commented May 28, 2018

Triggering tests

mbed-ci commented May 28, 2018

mbed-ci commented May 28, 2018

bulislaw commented May 28, 2018

mbed-ci commented May 28, 2018

Triggering tests

mprse commented May 28, 2018 • edited Loading

mbed-ci commented May 28, 2018

mbed-ci commented May 28, 2018

0xc0170 commented May 28, 2018

ithinuel commented May 28, 2018

ithinuel left a comment

Choose a reason for hiding this comment

mprse commented May 28, 2018

bulislaw commented May 25, 2018 •

edited

Loading

mprse commented May 25, 2018 •

edited

Loading

mprse commented May 25, 2018 •

edited

Loading

mprse commented May 28, 2018 •

edited

Loading