Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SWI conflict in SoftDevice for NRF52 series #7453

Merged
merged 3 commits into from
Jul 11, 2018
Merged

Fix SWI conflict in SoftDevice for NRF52 series #7453

merged 3 commits into from
Jul 11, 2018

Conversation

marcuschangarm
Copy link
Contributor

Description

SWI channels reserved for the SoftDevice were incorrectly defined leading to conflicts in the serial implementation. New serial driver only uses one SWI channel instead of four.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Marcus Chang added 3 commits July 9, 2018 12:54
All SWI channels except SWI0 is being used by the SoftDevice and
not only SWI1.
This fixes conflicts with the SoftDevice.
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 10, 2018

At least one user confirmed that this fixes the issue

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2018

Build : SUCCESS

Build number : 2555
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7453/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@NeilMacMullen
Copy link
Contributor

This seems to address the issue I was seeing in #7219 (comment) so is a significant improvement.

However, there still appears to be an issue with SPI. I'm still trying to pin this down but it appears that on one of the spi buses I am using, it's not possible to read data.

@mbed-ci
Copy link

mbed-ci commented Jul 10, 2018

@marcuschangarm
Copy link
Contributor Author

@NeilMacMullen

However, there still appears to be an issue with SPI. I'm still trying to pin this down but it appears that on one of the spi buses I am using, it's not possible to read data.

Is this a new issue or do you have an open github issue for it?

@NeilMacMullen
Copy link
Contributor

NeilMacMullen commented Jul 10, 2018

@marcuschangarm It's 'new' in the sense that I only discovered it after overcoming the initial problems and it doesn't currently have its own issue id. I don't think it was caused by this fix and may have been present on master for some time, I only mentioned it here in case some variation of this fix might be relevant to SPI as well. Probably best if I raise a separate ticket for it.

@marcuschangarm
Copy link
Contributor Author

I only mentioned it here in case some variation of this fix might be relevant to SPI as well.

I don't recall any direct dependencies between SPI and UART/BLE.

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jul 11, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

@NeilMacMullen If there isn't already an issue open, please go ahead and open one. We can track problems better when they're in a GitHub issues instead of comments in PRs.

Bringing this in since the PR appears to address its initial problem scope.

@cmonr cmonr merged commit 38c5e9c into ARMmbed:master Jul 11, 2018
@AGlass0fMilk
Copy link
Member

Resolves #7440

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Fix SWI conflict in SoftDevice for NRF52 series
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants