-
Notifications
You must be signed in to change notification settings - Fork 3k
Raytac: target removal #7461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raytac: target removal #7461
Conversation
No files to build - should not be in targets Reverts part of the ARMmbed#6178
Fixes #7460 |
Will start CI once @andrewleech has ack'd. |
/morph build |
Started CI since another PR is waiting on this to come in. @andrewleech Feel free to still confirm. |
Build : SUCCESSBuild number : 2592 Triggering tests/morph test |
Hi, I'm fine with it being removed, if I see a need in future I'll open a new PR with some better testing on my end to add all the needed files. fyi In our project this was actually an intermediate target defining the common stuff for the off-the-shelf module and I had a second target in my custom_targets file with the pinouts etc of the custom pcb the module was mounted on. |
Exporter Build : SUCCESSBuild number : 2235 |
Thanks @andrewleech for the info. Once test passes, will be ready to go in. |
Test : SUCCESSBuild number : 2345 |
Raytac: target removal
No files to build - should not be in targets
Reverts part of the #6178
This target should not be defined in targets (no files related in the codebase).
@andrewleech
Description
Pull request type