Skip to content

Raytac: target removal #7461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Raytac: target removal #7461

merged 1 commit into from
Jul 13, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jul 10, 2018

No files to build - should not be in targets
Reverts part of the #6178

This target should not be defined in targets (no files related in the codebase).

@andrewleech

Description

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

No files to build - should not be in targets
Reverts part of the ARMmbed#6178
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 10, 2018

Fixes #7460

@cmonr
Copy link
Contributor

cmonr commented Jul 10, 2018

Will start CI once @andrewleech has ack'd.

@cmonr
Copy link
Contributor

cmonr commented Jul 12, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Jul 12, 2018

Started CI since another PR is waiting on this to come in.

@andrewleech Feel free to still confirm.

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2018

Build : SUCCESS

Build number : 2592
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7461/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@andrewleech
Copy link
Contributor

Hi,
Sorry I thought I had added the files needed for this target to build by itself, clearly I hadn't done enough.

I'm fine with it being removed, if I see a need in future I'll open a new PR with some better testing on my end to add all the needed files.

fyi In our project this was actually an intermediate target defining the common stuff for the off-the-shelf module and I had a second target in my custom_targets file with the pinouts etc of the custom pcb the module was mounted on.

@mbed-ci
Copy link

mbed-ci commented Jul 12, 2018

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jul 13, 2018

Thanks @andrewleech for the info. Once test passes, will be ready to go in.

@mbed-ci
Copy link

mbed-ci commented Jul 13, 2018

@cmonr cmonr merged commit 531ee3c into ARMmbed:master Jul 13, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants