Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MTS Dragonfly bootloader back after accidental removal from pr #7131 #7480

Merged
merged 1 commit into from
Jul 23, 2018
Merged

Add MTS Dragonfly bootloader back after accidental removal from pr #7131 #7480

merged 1 commit into from
Jul 23, 2018

Conversation

klaas019
Copy link

Description

Accidently removed mts_dragonfly bootloader when adding new mts_mdot bootloader

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@cmonr
Copy link
Contributor

cmonr commented Jul 12, 2018

@klaas019 Could you ammend the commit message so that it reflects this PR a bit better?

Also, would you mind referencing which PR originally removed the file?

@klaas019 klaas019 changed the title Add files via upload Added MTS Dragonfly bootloader back after accidental removal. Jul 12, 2018
@klaas019 klaas019 changed the title Added MTS Dragonfly bootloader back after accidental removal. Added MTS Dragonfly bootloader back after accidental removal from pr #7131. Jul 12, 2018
@klaas019
Copy link
Author

Is that correct?

@cmonr
Copy link
Contributor

cmonr commented Jul 12, 2018

Close but not quite.
The commit itself should be updated to reflect the changes.

Take a look at git commit --amend to modify the commit mesasge.

@0xc0170 0xc0170 changed the title Added MTS Dragonfly bootloader back after accidental removal from pr #7131. Add MTS Dragonfly bootloader back after accidental removal from pr #7131 Jul 13, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2018

Will wait for the commit to be updated

@klaas019
Copy link
Author

I believe I did this correctly

@cmonr
Copy link
Contributor

cmonr commented Jul 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Build : SUCCESS

Build number : 2650
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7480/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 19, 2018

Exporter Build : SUCCESS

Build number : 2283
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7480/

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 20, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Jul 20, 2018

Test : SUCCESS

Build number : 2393
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7480/2393

@cmonr cmonr merged commit 25bb200 into ARMmbed:master Jul 23, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7480 from klaas019/master
8cb4956 
Add MTS Dragonfly bootloader back after accidental removal from pr ARMmbed#7131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: 5.9.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klaas019 @cmonr @0xc0170 @mbed-ci