-
Notifications
You must be signed in to change notification settings - Fork 3k
Tools: Select compiler based on arch version #7558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
And pick the correct compiler
tools/toolchains/arm.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
archetecture typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for throwing this error when using ARM Compiler 6 with v6m or v7m target?
From the compiler's view, the message could be misleading. Becuase ARM compiler officially claims the support for architectures from Armv6m and all the later ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't test that combination.
526e501 to
3f68411
Compare
|
@0xc0170 Fixed typo |
|
@theotherjimmy From Travis: |
|
Weird. That should be a bound method. |
|
Diff says enough. |
|
/morph build |
|
@ARMmbed/mbed-os-test |
Build : SUCCESSBuild number : 2670 Triggering tests/morph test |
|
CI should not require changes, as armc6 is configured on the nodes. |
Exporter Build : SUCCESSBuild number : 2303 |
Test : SUCCESSBuild number : 2409 |
|
/morph build |
Build : SUCCESSBuild number : 2673 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2306 |
Test : SUCCESSBuild number : 2411 |
Tools: Select compiler based on arch version
Description
This allows users to use the approprate arm compiler with the
-t ARMswitch. It picks Arm Compiler 5 for v6m and v7m and picks Arm Compiler 6
for v8m.
This also emits an error (but still builds) with
-t ARMC6and v6m andv7m.
Pull request type