Skip to content

Conversation

@theotherjimmy
Copy link
Contributor

@theotherjimmy theotherjimmy commented Jul 19, 2018

Description

This allows users to use the approprate arm compiler with the -t ARM
switch. It picks Arm Compiler 5 for v6m and v7m and picks Arm Compiler 6
for v8m.

This also emits an error (but still builds) with -t ARMC6 and v6m and
v7m.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@cmonr cmonr requested review from a team, 0xc0170, SenRamakri and cmonr July 20, 2018 01:47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

archetecture typo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for throwing this error when using ARM Compiler 6 with v6m or v7m target?

From the compiler's view, the message could be misleading. Becuase ARM compiler officially claims the support for architectures from Armv6m and all the later ones.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't test that combination.

@theotherjimmy
Copy link
Contributor Author

@0xc0170 Fixed typo

@cmonr
Copy link
Contributor

cmonr commented Jul 20, 2018

@theotherjimmy From Travis:

E           TypeError: unbound method cc_info() must be called with MockNotifier instance as first argument (got dict instance instead)

@theotherjimmy
Copy link
Contributor Author

Weird. That should be a bound method.

@theotherjimmy
Copy link
Contributor Author

Diff says enough.

@cmonr
Copy link
Contributor

cmonr commented Jul 25, 2018

/morph build

@cmonr
Copy link
Contributor

cmonr commented Jul 25, 2018

@ARMmbed/mbed-os-test
This will be needed to update our CI to start building against ARMc6. Will this change need to come into a versioned mbed-os, or is having it in master sufficient to move things forward?

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

Build : SUCCESS

Build number : 2670
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7558/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@studavekar
Copy link
Contributor

CI should not require changes, as armc6 is configured on the nodes.

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

@cmonr
Copy link
Contributor

cmonr commented Jul 25, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

Build : SUCCESS

Build number : 2673
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7558/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

@mbed-ci
Copy link

mbed-ci commented Jul 25, 2018

@cmonr cmonr merged commit dcd358f into ARMmbed:master Jul 26, 2018
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Tools: Select compiler based on arch version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants