Skip to content

realtek rtl8195am SLEEP feature implementation and lib updates #7638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

M-ichae-l
Copy link
Contributor

Description

1, Rtl8195am lib updates. Sync with the latest rtl8195am SDK.
2, Add sleep feature. Add "sleep_ex_api.h", "sleep.c" and "sleep_api.c".
3, Edit api files to fit the new lib updates.

Pull request type

[X] Feature

1, lib updates. Sync with the latest rtl8195am SDK
2, Add sleep features. Add "sleep_ex_api.h", "sleep.c" and "sleep_api.c"
3, edit api files to fit new lib
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add license for ram_1.bin ?

}

// Initial a G-Timer
#if 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead code, please remove

* }
* @endcode
*/
#if 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This #if should also be cleaned up

@M-ichae-l
Copy link
Contributor Author

@0xc0170
"lp_ticker_api.c" is an extra file. So remove it for this PR.

@M-ichae-l
Copy link
Contributor Author

@0xc0170
For the ram_1.bin, could you give some suggestions about how to add the license?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 30, 2018

Add LICENSE file and specify binary license. I assume this would be Permissive Binary License ?

@M-ichae-l
Copy link
Contributor Author

@0xc0170
Thank you!
I have checked the bootloaders file. There are 4 targets and all of them do not have LICENSE (including RTL8195AM, previously from the master branch). Are you going to request all targets to add LICENSE or just the RTL8195AM?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 31, 2018

I was going to create a tracking issue for this, will do asap (they should have).

Update: Tracking issue created for the rest of the bootloaders there.

@M-ichae-l
Copy link
Contributor Author

@0xc0170
I have committed a license for bootloader. Could you double check if the license is acceptable?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 2, 2018

Thanks, looks good to me

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few libraries updated here, and I checked if they have license (they don't). Can you please send a separate pull request adding the license for those libraries (driver/wlan) ?

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 2, 2018

/morph build

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 2, 2018

To be specific: lib_peripheral and lib_wlan libs - license

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

Build : SUCCESS

Build number : 2723
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7638/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 2, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 2, 2018

@M-ichae-l Would you mind taking a look at the tests-mbed_hal-sleep test failures?

@M-ichae-l
Copy link
Contributor Author

M-ichae-l commented Aug 3, 2018

@cmonr
The tests-mbed_hal-sleep test failures are related to sleep_usticker_test. However, the new us_ticker (also lp_ticker) features have not been implemented yet. The failures are expected to appear.

@cmonr
Copy link
Contributor

cmonr commented Aug 3, 2018

Interesting, and thanks for the additional info.

Do you have any idea if fixes will be coming into this PR for them, or if there's another PR/issue that is being worked on to resolve them? I'm afraid we can't bring something in that we know would fail tests.

@M-ichae-l
Copy link
Contributor Author

@cmonr
Let me apply fixes in this PR to pass the sleep_usticker_test. Thank you!
The new us ticker and lp ticker features will be updated in another coming PR once it is ready.

1, replace "us_ticker.c" with "us_ticker_api.c". To correct the return of "us_ticker_read(void)" and pass the "sleep_usticker_test"
@M-ichae-l
Copy link
Contributor Author

M-ichae-l commented Aug 3, 2018

@cmonr
I have use a new us_ticker_api.c to replace the old us_ticker.c. The new us_ticker_api.c fix return of us_ticker_read(void) to be ticks. This fix will let the sleep_usticker_test pass.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 3, 2018

There's conflict now, please resolve

@M-ichae-l
Copy link
Contributor Author

@0xc0170
I don't have the write access to resolve the conflicts. Could I have the access? Also, I did not see the conflicts offline. Please let me see the conflicts online.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 6, 2018

M-ichae-l:realtek-rtl8195am-SLEEP-features-implementation - this is where to resolve the conflicts. You shall rebase this branch on top of master

I would do:

git checkout master
git pull --rebase upstream master #upstream is Mbed OS git repository
git checkout realtek-rtl8195am-SLEEP-features-implementation
git rebase master # right now will display conflicts and asks you to resolve them

@M-ichae-l
Copy link
Contributor Author

@0xc0170
Please refer to #7715 for the rebase and resolved conflicts.

We can close this PR.

@0xc0170 0xc0170 closed this Aug 7, 2018
@M-ichae-l M-ichae-l deleted the realtek-rtl8195am-SLEEP-features-implementation branch October 26, 2018 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants