-
Notifications
You must be signed in to change notification settings - Fork 3k
iar: remove nxp duplicate definitions #7640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@theotherjimmy / @adbridge can you verify these duplicates? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I see the incorrect duplicates are
"MK22DN512xxx5": {
"OGChipSelectEditMenu": "MK22FN512xxx12\tFreescale MK22FN512xxx12"
and
"MK22DN512xxx5": {
"OGChipSelectEditMenu": "MK22DN512xxx5\tNXP MK22DN512xxx5"
One 12 and one 5 as you say. Just need to double check that we are removing the correct one.
Fixed. Based on the CMSIS pack info, K22F board should contain xxx12 MCU thus corrected and xxx5 removed as its not used anywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks more consistent now.
cb936a0
to
343640f
Compare
IAR 7.80 has only xxx5 device (DNxxx5) thus using that one in case of IAR. Tested locally |
84f018a
to
6f8074d
Compare
Based on the https://www.keil.com/boards2/nxp/frdm_k22f/ - it contains xxx12 MCU. However IAR 7.80 has only xxx5 version, thus leaving NXP added version as xxx5.
6f8074d
to
6f6a516
Compare
uvision and IAR works. However for uvision, device_name seems to be deprecated (shows me deprecated in the device selection in uvision). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good.
/morph build |
Build : SUCCESSBuild number : 2741 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 2373 |
Test : SUCCESSBuild number : 2466 |
@0xc0170 Could you locally confirm the error? It's possible this might be related to IAR issues we've been seeing, but it would be good to confirm first. |
I did locally, but will do again the same as exporters do. It looks like this is error in this PR. I'll check |
This fixes the failure for IAR regarding floating point.
I was able to reproduce the failure. It should be now fixed! |
/morph build |
Build : SUCCESSBuild number : 2753 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2383 |
Test : SUCCESSBuild number : 2477 |
…cate iar: remove nxp duplicate definitions
Description
Fixes #7634
Removing 2 duplicates (one was even using wrong device - instead of ....5 was .....12)
Pull request type