Add required header file and namespace element instead add all. #7864

deepikabhavnani · 2018-08-22T17:58:40Z

Description

Source inside mbed-os should not be using "mbed.h" even in CPP files, instead required header file and namespace should be explicitly added inside mbed-os

With #7760 PR, we will give an option to remove namespace.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

pan- · 2018-08-22T18:46:52Z

events/EventQueue.cpp


+using namespace events;


Please enclose the definitions inside the namespace event. using is not meant to be use that way:

namespace events { // definitions } // namespace event

deepikabhavnani · 2018-09-05T14:36:58Z

Rebased to resolve conflicts

geky

this is looking good 👍

0xc0170 · 2018-10-01T13:59:38Z

/morph build

…d all

deepikabhavnani · 2018-10-15T15:40:20Z

Rebased to resolve conflicts

cmonr · 2018-10-19T19:51:05Z

@bulislaw @pan- @geky Thoughts?

0xc0170 · 2018-10-24T12:36:52Z

Last round of reviews opened !

pan-

Looks good to me.

pan- · 2018-10-24T13:29:38Z

platform/ATCmdParser.cpp

@@ -102,7 +107,7 @@ int ATCmdParser::read(char *data, int size)


 // printf/scanf handling
-int ATCmdParser::vprintf(const char *format, va_list args)
+int ATCmdParser::vprintf(const char *format, std::va_list args)


std::vaargs types are in #include <cstdarg> How is it included ?

platform/ATCmdParser.h includes cstdarg

https://github.com/ARMmbed/mbed-os/pull/7864/files/1d23843833c19d913601f40e34ef3880f0a3a77c#diff-61ea3747ffa004896edb10ecbdcdc1a0R23

0xc0170 · 2018-10-24T13:52:39Z

/morph build

mbed-ci · 2018-10-24T14:59:52Z

Build : SUCCESS

Build number : 3452
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7864/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-24T16:22:28Z

Exporter Build : SUCCESS

Build number : 3074
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7864/

mbed-ci · 2018-10-24T17:34:17Z

Test : SUCCESS

Build number : 3244
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7864/3244

cmonr · 2018-10-25T01:27:38Z

@bulislaw @geky @kjbracey-arm Final call to review. Otherwise will go in early tomorrow.

deepikabhavnani force-pushed the remove_mbed_h branch from f031ea0 to de2a04a Compare August 22, 2018 18:01

pan- reviewed Aug 22, 2018

View reviewed changes

deepikabhavnani force-pushed the remove_mbed_h branch from de2a04a to c4a6662 Compare August 22, 2018 19:04

deepikabhavnani mentioned this pull request Aug 22, 2018

Give an option to remove 'using namespace' #7760

Merged

deepikabhavnani force-pushed the remove_mbed_h branch 3 times, most recently from 1cda348 to 5106000 Compare August 22, 2018 20:52

deepikabhavnani mentioned this pull request Aug 22, 2018

Add required header files from mbed-os ARMmbed/wizfi310-driver#7

Merged

deepikabhavnani added the needs: work label Aug 22, 2018

deepikabhavnani force-pushed the remove_mbed_h branch from 5106000 to 86104a1 Compare August 23, 2018 16:38

deepikabhavnani requested review from geky and kjbracey August 23, 2018 16:38

deepikabhavnani force-pushed the remove_mbed_h branch from 86104a1 to 86b2fb3 Compare August 24, 2018 16:39

deepikabhavnani added needs: review and removed needs: work labels Aug 24, 2018

deepikabhavnani force-pushed the remove_mbed_h branch from 86b2fb3 to 2679c99 Compare September 5, 2018 14:36

deepikabhavnani removed request for geky and kjbracey September 5, 2018 14:37

deepikabhavnani force-pushed the remove_mbed_h branch 2 times, most recently from 040bff8 to 2b2b20b Compare September 5, 2018 15:10

deepikabhavnani requested a review from geky September 12, 2018 22:03

bmcdonnell-ionx mentioned this pull request Sep 13, 2018

USB device cleanup #8125

Closed

geky approved these changes Sep 19, 2018

View reviewed changes

0xc0170 requested a review from a team September 20, 2018 12:49

0xc0170 approved these changes Sep 20, 2018

View reviewed changes

SenRamakri approved these changes Sep 20, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 1, 2018

Deepika added 4 commits October 15, 2018 10:39

EventQueue: Add required header file and namespace element instead ad…

fdcd51d

…d all

RTOS: Add required header file and namespace element instead add all

3d5ec66

ATCmdParser: Added namespace std for va_list

f55b929

Platform: Add required header file and namespace element instead add all

1d23843

deepikabhavnani force-pushed the remove_mbed_h branch from 6193510 to 1d23843 Compare October 15, 2018 15:39

deepikabhavnani requested review from pan- and geky and removed request for pan-, geky and 0xc0170 October 15, 2018 15:40

cmonr requested a review from kjbracey October 19, 2018 19:51

pan- approved these changes Oct 24, 2018

View reviewed changes

cmonr added ready for merge release-version: 5.11.0-rc1 and removed needs: review labels Oct 25, 2018

cmonr added release-version: 5.10.3 and removed release-version: 5.11.0-rc1 labels Oct 25, 2018

cmonr merged commit 9c59d9a into ARMmbed:master Oct 25, 2018

cmonr removed the ready for merge label Oct 25, 2018

deepikabhavnani deleted the remove_mbed_h branch October 26, 2018 15:59

0xc0170 added release-version: 5.11.0-rc1 and removed release-version: 5.10.3 labels Nov 5, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add required header file and namespace element instead add all. #7864

Add required header file and namespace element instead add all. #7864

Uh oh!

deepikabhavnani commented Aug 22, 2018

Uh oh!

pan- Aug 22, 2018

Uh oh!

deepikabhavnani commented Sep 5, 2018

Uh oh!

geky left a comment

Uh oh!

0xc0170 commented Oct 1, 2018

Uh oh!

deepikabhavnani commented Oct 15, 2018

Uh oh!

cmonr commented Oct 19, 2018

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

pan- left a comment

Uh oh!

pan- Oct 24, 2018

Uh oh!

deepikabhavnani Oct 24, 2018 •

edited

Loading

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

mbed-ci commented Oct 24, 2018

Uh oh!

mbed-ci commented Oct 24, 2018

Uh oh!

mbed-ci commented Oct 24, 2018

Uh oh!

cmonr commented Oct 25, 2018 •

edited

Loading

Uh oh!

Uh oh!

Add required header file and namespace element instead add all. #7864

Add required header file and namespace element instead add all. #7864

Uh oh!

Conversation

deepikabhavnani commented Aug 22, 2018

Description

Pull request type

Uh oh!

pan- Aug 22, 2018

Choose a reason for hiding this comment

Uh oh!

deepikabhavnani commented Sep 5, 2018

Uh oh!

geky left a comment

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 1, 2018

Uh oh!

deepikabhavnani commented Oct 15, 2018

Uh oh!

cmonr commented Oct 19, 2018

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

pan- left a comment

Choose a reason for hiding this comment

Uh oh!

pan- Oct 24, 2018

Choose a reason for hiding this comment

Uh oh!

deepikabhavnani Oct 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Oct 24, 2018

Uh oh!

mbed-ci commented Oct 24, 2018

Build : SUCCESS

Triggering tests

Uh oh!

mbed-ci commented Oct 24, 2018

Exporter Build : SUCCESS

Uh oh!

mbed-ci commented Oct 24, 2018

Test : SUCCESS

Uh oh!

cmonr commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

deepikabhavnani Oct 24, 2018 •

edited

Loading

cmonr commented Oct 25, 2018 •

edited

Loading