Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export, Embitz: Avoid assigning self.resources.linker_script #7939

Merged
merged 1 commit into from
Sep 6, 2018

Conversation

theotherjimmy
Copy link
Contributor

Description

At some point in the past, self.linker_script was changed from
"assignable" to not allowing assignment. This PR changes the Embitz
exporter to avoid assigning this variable, and therefore fixes the
exporter. This change also simplifies the expoter code

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Avoids assigning to things that we can't assign
@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

Build : FAILURE

Build number : 3016
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7939/

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

Strange that this temp file error is starting to show up...

ToolException: Fatal error: A1023E: File "/tmp/file44uSrI" could not be opened: No such file or directory

/morph build

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

@ARMmbed/mbed-os-test ^^^

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

Build : SUCCESS

Build number : 3019
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7939/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 6, 2018

License server problem

cc @OPpuolitaival

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

Another ARM network license issue.
Fyi @ARMmbed/mbed-os-test

@mbed-ci
Copy link

mbed-ci commented Sep 6, 2018

@cmonr cmonr merged commit 27f3fd9 into ARMmbed:master Sep 6, 2018
@0xc0170 0xc0170 removed the needs: CI label Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants