nrf52-ble: fix total links count

[pingdan32]

Description

I think I found a bug about the NRF52 series. The NRF_SDH_BLE_TOTAL_LINK_COUNT is NOT defined in any configuration file except sdk_config.h. This causes the actual number of total links to be inconsistent with the definition when central_link_count or peripheral_link_count is configured via features/FEATURE_BLE/targets/TARGET_NORDIC/mbed_lib.json.

This PR fixes this bug and I think this is a good way. Please review.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

[0xc0170]

@ARMmbed/mbed-os-pan Please review

[pan-]

TOTAL_LINK_COUNT is the number of concurrent connections which, at most, will be equal to the number of central and peripheral links count if peripheral and central roles operates in parallel.

If peripheral and central roles do not operate in parallel in the application then TOTAL_LINK_COUNT should be equal to max(CENTRAL_LINK_COUNT, PERIPHERAL_LINK_COUNT).

In the end, TOTAL_LINK_COUNT depends on the application. Unfortunately the fix proposed doesn't fit everyone needs.

@donatieng What should be the default value ?

[pingdan32]

@pan-

In the end, TOTAL_LINK_COUNT depends on the application. Unfortunately the fix proposed doesn't fit everyone needs.

The key to the problem is how to distinguish the role of the application. I think that it is not as good as user configuration by tools detection. CENTRAL_LINK_COUNT and PERIPHERAL_LINK_COUNT have been configured by the user, so we should trust that it is what the user needs. In other words, if the application is only in CENTRAL mode, then CENTRAL_LINK_COUNT=x PERIPHREAL_LINK_COUNT=0 should be configured. All we have to do is trust the user, not overdetect.

[pan-]

@pingdan32 I believe an entry config file would solves everyone problems:

        "total_link_count": {
            "help": "How many concurrent connections the system support.",
            "value": "(NRF_SDH_BLE_CENTRAL_LINK_COUNT + NRF_SDH_BLE_PERIPHERAL_LINK_COUNT)",
            "macro_name": "NRF_SDH_BLE_TOTAL_LINK_COUNT"
        },

What do you think ?

[pingdan32]

@pingdan32 I believe an entry config file would solves everyone problems:

        "total_link_count": {
            "help": "How many concurrent connections the system support.",
            "value": "(NRF_SDH_BLE_CENTRAL_LINK_COUNT + NRF_SDH_BLE_PERIPHERAL_LINK_COUNT)",
            "macro_name": "NRF_SDH_BLE_TOTAL_LINK_COUNT"
        },

What do you think ?

😁Good idea! I can't agree more.

Changes addressed. Review?

[cmonr]

@pan- Mind re-reviewing?

[0xc0170]

/morph build

[mbed-ci]

Build : FAILURE

Build number : 3438
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7966/

[0xc0170]

Failures look unrelated, seems like CI did not cleanup properly, restarting

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 3441
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7966/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 3062
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7966/

[cmonr]

/morph mbed2-build

[mbed-ci]

Test : SUCCESS

Build number : 3229
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7966/3229