-
Notifications
You must be signed in to change notification settings - Fork 3k
BLE: fix missing updates sent callback in GattServer using Cordio stack #7981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b536572
to
ec373c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The write
overload should be modified too:
mbed-os/features/FEATURE_BLE/targets/TARGET_CORDIO/source/CordioGattServer.cpp
Lines 685 to 693 in ec373c2
if (is_update_authorized(connection, att_handle)) { | |
uint16_t cccEnabled = AttsCccEnabled(connection, cccd_index); | |
if (cccEnabled & ATT_CLIENT_CFG_NOTIFY) { | |
AttsHandleValueNtf(connection, att_handle, len, (uint8_t*)buffer); | |
} | |
if (cccEnabled & ATT_CLIENT_CFG_INDICATE) { | |
AttsHandleValueInd(connection, att_handle, len, (uint8_t*)buffer); | |
} | |
} |
@pan- fixed |
/morph build |
Build : SUCCESSBuild number : 3084 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2694 |
Test : SUCCESSBuild number : 2873 |
Description
Calling onDataSent registers a callback to be notified of updates sent. Cordio implementation of the GattServer doesn't call this callback. This adds the call.
Pull request type