Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: fix missing updates sent callback in GattServer using Cordio stack #7981

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

paul-szczepanek-arm
Copy link
Member

Description

Calling onDataSent registers a callback to be notified of updates sent. Cordio implementation of the GattServer doesn't call this callback. This adds the call.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@paul-szczepanek-arm paul-szczepanek-arm changed the title BLE: added missing callback to cordio after updates are sent BLE: fix missing updates sent callback in GattServer using Cordio stack Sep 4, 2018
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The write overload should be modified too:

if (is_update_authorized(connection, att_handle)) {
uint16_t cccEnabled = AttsCccEnabled(connection, cccd_index);
if (cccEnabled & ATT_CLIENT_CFG_NOTIFY) {
AttsHandleValueNtf(connection, att_handle, len, (uint8_t*)buffer);
}
if (cccEnabled & ATT_CLIENT_CFG_INDICATE) {
AttsHandleValueInd(connection, att_handle, len, (uint8_t*)buffer);
}
}

@paul-szczepanek-arm
Copy link
Member Author

@pan- fixed

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

Build : SUCCESS

Build number : 3084
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7981/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

@cmonr cmonr merged commit c3128cd into ARMmbed:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants