Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoRaWAN: Memory overrun correction #7982

Merged
merged 1 commit into from
Sep 17, 2018
Merged

Conversation

hasnainvirk
Copy link
Contributor

Description

A typo in LoRaPHYCN470 is causing memory overrun.
We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

A typo in LoRaPHYCN470 is causing memory overrun.
We were supposed to fill-in default channel mask and iterate over CN470_CHANNEL_MASK_SIZE times.
@hasnainvirk
Copy link
Contributor Author

@0xc0170 @kjbracey-arm Please review. This needs immediate CI and merge.

@hasnainvirk
Copy link
Contributor Author

@0xc0170 @cmonr This one is still lingering here ?

@kjbracey
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2018

Build : SUCCESS

Build number : 3042
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7982/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2018

@hasnainvirk
Copy link
Contributor Author

@cmonr @0xc0170 The failure is not related to this PR. Please re-run CI.

@mbed-ci
Copy link

mbed-ci commented Sep 10, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 10, 2018

@hasnainvirk Will restart both export and test CI in a bit. Current queues a bit long.

@hasnainvirk
Copy link
Contributor Author

hasnainvirk commented Sep 12, 2018

@cmonr Have we missed this again ?? This is a broken , we must get this PR in as fast as we can. It's been about 8 days now, this PR is just a one liner !

@cmonr
Copy link
Contributor

cmonr commented Sep 12, 2018

@hasnainvirk We missed this because we've been prioritizing PRs needed for 5.10 RCs.

/morph test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 12, 2018

@kivaisan
Copy link
Contributor

@cmonr Could you please reconsider this to be part of 5.10.0? This is a quite bad memory corruption bug.

@hasnainvirk
Copy link
Contributor Author

@cmonr This must go in as soon as possible. Please prioritise.

@adbridge
Copy link
Contributor

@ChiefBureaucraticOfficer Could you please let us know if you think this should come in to 5.10 as requested by @hasnainvirk . AFAIK it has not been seen in OOB so would technically not normally be considered.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 17, 2018

If this is not critical/blocker, this will go 5.10.1. This is now going in, the label can be updated on request.

@0xc0170 0xc0170 merged commit aca7740 into ARMmbed:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants