Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with LowPowerTickerWrapper #8029

Merged
merged 1 commit into from
Sep 19, 2018

Conversation

ccli8
Copy link
Contributor

@ccli8 ccli8 commented Sep 7, 2018

Description

On all Nuvoton targets, LPTICKER_DELAY_TICKS is enabled which relies on LowPowerTickerWrapper. This PR tries to fix some corner case errors with LowPowerTickerWrapper:

  1. _ticker_match_interval_passed doesn't see _last_set_interrupt == _cur_match_time as matched. Add extra check for it.
  2. Fix "too close" check with _min_count_until_match.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

1. Complement _ticker_match_interval_passed with '_last_set_interrupt == _cur_match_time' for pass check
2. Fix 'too close' check with _min_count_until_match
Copy link
Contributor

@c1728p9 c1728p9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @ccli8. @cmonr this is something you'll probably want for 5.10.1

@cmonr
Copy link
Contributor

cmonr commented Sep 19, 2018

Thanks for the heads up. Initially missed it since the Nuvoton PRs have generally had something in the totle indicating as such.

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3103
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8029/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@0xc0170 0xc0170 merged commit 962273c into ARMmbed:master Sep 19, 2018
@ccli8 ccli8 deleted the nuvoton_fix_lpticker_wrapper branch October 2, 2018 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants