Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling fixes and general readability improvements for TEST_APPS documentation #8067

Merged
merged 2 commits into from
Sep 17, 2018

Conversation

bridadan
Copy link
Contributor

Description

This PR is part of the 5.10 OOB process.

I've included some spelling fixes and general readability improvements to the TEST_APPS documentation. None of the changes are particularly technical, I was just making tweaks as I read the document.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Extend copy edits.
Copy link
Contributor

@AnotherButler AnotherButler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bridadan 👍 Thanks for the great copy edits. I've added some more on top of yours.

@bridadan
Copy link
Contributor Author

Your edits look great, thanks @AnotherButler!

You probably want to add the log folder to your .mbedignore file to prevent issues with build commands becoming too long over the time.
You can also find the results from the tests in the `mbed-os/log` folder.

You probably want to add the log folder to your `.mbedignore` file to prevent issues with build commands becoming too long over the time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why build command touch even log files? Could it be ignored by default?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SeppoTakalo @OPpuolitaival Could y'all address this question?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the concern is that mbed-os/log adds another include directory to the already long list of include directories. As long as no subdirectories are added to mbed-os/log, I think it'd be safe to remove this section in the docs.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know that its always mbed-os/log then I would be happy to add that into .mbedignore file, just to be safe.

Copy link
Contributor

@SeppoTakalo SeppoTakalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 16, 2018

Build : SUCCESS

Build number : 3080
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8067/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 16, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 17, 2018

@0xc0170 0xc0170 merged commit d02cd70 into ARMmbed:master Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants