Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gt netsocket tcp - increases threads' stack size #8132

Merged
merged 3 commits into from
Sep 27, 2018
Merged

gt netsocket tcp - increases threads' stack size #8132

merged 3 commits into from
Sep 27, 2018

Conversation

VeijoPesonen
Copy link
Contributor

Description

Greentea netsocket tcp test cases - used thread stack size was insufficient for debug profile.
Also insufficient thread stack size with NUCLEO_F401RE+IDW01M1 - please see issue ARMmbed/wifi-x-nucleo-idw01m1#17

Test case timeout value increased because demanded by the new ARMmbed/esp8266-driver#83

Patch (commit) 24905f5 provided by @betzw.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@VeijoPesonen
Copy link
Contributor Author

@betzw, @juhaylinen - includes everything required by ARMmbed/wifi-x-nucleo-idw01m1#17? @kjbracey-arm, @SeppoTakalo please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3110
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8132/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

@VeijoPesonen
Copy link
Contributor Author

VeijoPesonen commented Sep 20, 2018

Hmm, I claim this one:

BUILD/tests/ARCH_PRO/GCC_ARM/TESTS/netsocket/tcp/tcp.bin , TCPSOCKET_ECHOTEST_NONBLOCK - might be that the stack size got too big

Other failures, not caused by these test case changes:

BUILD/tests/LPC546XX/GCC_ARM/TESTS/mbed_drivers/crc/crc.bin , tests-mbed_drivers-crc
BUILD/tests/LPC546XX/ARM/TESTS/netsocket/dns/dns.bin , tests-netsocket-dns
BUILD/tests/LPC546XX/ARM/TESTS/netsocket/dns/dns.bin , features-frameworks-utest-tests-unit_tests-case_control_async
BUILD/tests/LPC546XX/IAR/TESTS/mbed_hal/us_ticker/us_ticker.bin , tests-mbed_hal-us_ticker

BUILD/tests/NUCLEO_F746ZG/ARM/TESTS/mbed_drivers/lp_ticker/lp_ticker.bin , tests-mbed_drivers-lp_ticker

@VeijoPesonen
Copy link
Contributor Author

VeijoPesonen commented Sep 21, 2018

@betzw could you check if 2048B as stack size is sufficient with NUCLEO_F401RE? It seems to be enough for debug profile with K64F.

@betzw
Copy link
Contributor

betzw commented Sep 21, 2018

Well, I will check, but what I can already say is that I know of some demo application (e.g. mbed_cloud_client) where a stack size of 4K was necessary!
Btw, I think that stack size is less dependent on the board/chip but typically much more on the application you run. It might be that a stack overflow on the NUCLEO_F401RE leads more easily to memory corruption than on other platforms, which mostly depends on the memory layout (i.e. linker script) for a specific platform.

@VeijoPesonen
Copy link
Contributor Author

The stack size we are talking here is only for the threads created specifically in these netsocket tcp cases. Doesn't have systemwide affect.

@VeijoPesonen
Copy link
Contributor Author

@betzw have you had time yet to check this?

@betzw
Copy link
Contributor

betzw commented Sep 26, 2018

Not yet.

@betzw
Copy link
Contributor

betzw commented Sep 26, 2018

netsocket-tcp test run on my side also with 2K of stack.

@VeijoPesonen
Copy link
Contributor Author

@betzw @SeppoTakalo @cmonr please review and and once it's done - needs: CI

Stack size is insufficient for debug profile
Stack size is insufficient for NUCLEO_F401RE+IDW01M1
Please see ARMmbed/wifi-x-nucleo-idw01m1#17
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3179
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8132/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@cmonr cmonr merged commit b1b6399 into ARMmbed:master Sep 27, 2018
@cmonr cmonr removed the needs: CI label Sep 27, 2018
@VeijoPesonen VeijoPesonen deleted the bugfix-tests-netsocket-tcp-stacksize branch September 28, 2018 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants