Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests: automatic unit test suite naming #8153

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Unit tests: automatic unit test suite naming #8153

merged 3 commits into from
Sep 20, 2018

Conversation

lorjala
Copy link
Contributor

@lorjala lorjala commented Sep 17, 2018

Description

Use unit test suite names automatically derived from the file path.

  • File paths are unique so test suite names are unique.
  • Same naming convention as previously.
  • No effect on existing tests.

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@lorjala lorjala mentioned this pull request Sep 17, 2018
Merged
@lorjala
Copy link
Contributor Author

lorjala commented Sep 17, 2018

FYI @OPpuolitaival @SeppoTakalo

OPpuolitaival
OPpuolitaival approved these changes Sep 17, 2018
View reviewed changes
Copy link
Contributor

@OPpuolitaival OPpuolitaival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cmonr
Copy link
Contributor

cmonr commented Sep 19, 2018

sigh

This needs a rebase. We'll start CI immediately after.

@lorjala
Copy link
Contributor Author

lorjala commented Sep 19, 2018

@0xc0170 @cmonr trigger build

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2018

@0xc0170 @cmonr trigger build

Waiting for 2 jobs to finish, will be triggered

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 19, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Build : SUCCESS

Build number : 3111
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8153/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 19, 2018

Exporter Build : SUCCESS

Build number : 2718
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8153/

@mbed-ci
Copy link

mbed-ci commented Sep 20, 2018

Test : SUCCESS

Build number : 2901
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8153/2901

@0xc0170 0xc0170 merged commit 6c34802 into ARMmbed:master Sep 20, 2018
@lorjala lorjala deleted the unittests-autoname branch November 19, 2018 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPpuolitaival OPpuolitaival OPpuolitaival approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lorjala @cmonr @0xc0170 @mbed-ci @OPpuolitaival @SeppoTakalo