Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix WIFI_CONNECT_PARAMS_CHANNEL_FAIL testcase. #8241

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

Test case was assuming that secure and unsecure SSID were on different
channels.
This is not a requirement and it should be OK to run on same channel.

Fixed the testcase by using +1 on channel number to get a wrong channel.

Fixes #8227

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

Test case was assuming that secure and unsecure SSID were on different
channels.
This is not a requirement and it should be OK to run on same channel.

Fixed the testcase by using +1 on channel number to get a wrong channel.
@SeppoTakalo
Copy link
Contributor Author

@VeijoPesonen Please review.

@SeppoTakalo
Copy link
Contributor Author

@0xc0170 Reviewed by Veijo.
Please remove the "Needs: review" label and add "Needs: CI" and then start the test.

Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

Build : SUCCESS

Build number : 3167
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8241/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

@VeijoPesonen
Copy link
Contributor

7:18:11 mbedgt: exporting to JUNIT file '/home/jenkins/k64f_test/workspace/test_matrix_raas/raas_matrix_job/target/LPC546XX/toolchain/GCC_ARM/test_report_LPC546XX-GCC_ARM.xml'...
17:18:11 mbedgt: exporting to HTML file '/home/jenkins/k64f_test/workspace/test_matrix_raas/raas_matrix_job/target/LPC546XX/toolchain/GCC_ARM/test_report_LPC546XX-GCC_ARM.html'...
17:18:11 mbedgt: unexpected error:
17:18:11 'time_start'

@0xc0170 failure seems to occur while writing a test report. Would you please restart the test job.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 5, 2018

Will restart the job once few jobs complete

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 6, 2018

Build : SUCCESS

Build number : 3261
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8241/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

@NirSonnenschein
Copy link
Contributor

/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 7, 2018

@cmonr cmonr merged commit 15879f5 into ARMmbed:master Oct 8, 2018
@SeppoTakalo SeppoTakalo deleted the fix_wifi_connect_params_fail branch October 17, 2018 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants