Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unittests: Add tests for netsocket classes #8316

Merged
merged 1 commit into from
Oct 10, 2018
Merged

unittests: Add tests for netsocket classes #8316

merged 1 commit into from
Oct 10, 2018

Conversation

michalpasztamobica
Copy link
Contributor

New classes covered with unit tests are: SocketAddress, EthernetInterface, EMACInterface,

Description

WiFiAccessPoint.
Also added missing namespace in front of mbed::Callback usages.
EMACInterface is covered by the EthernetInterface unit tests.

Pull request type

[ x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo please review

@SeppoTakalo
Copy link
Contributor

@0xc0170 Can you restart the travis check? Seems to have failed on connection error.

@michalpasztamobica
Copy link
Contributor Author

The CI build is failing due to an incorrect command when pip is installing astyle package. I can see that other builds also failed.
This command
tar xf astyle.tar.gz will fail to extract the gzipped file because the "z" option is missing.
tar xzf astyle.tar.gz should work better.
@0xc0170 @SeppoTakalo, do you agree? Is this a bug within pip or can this be fixed on Travis side?

@michalpasztamobica
Copy link
Contributor Author

Sorry, I checked that tar xf astyle_3.1_linux.tar.gz actually works fine on my machine. It must be a corrupted tar.gz file, then...

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

@0xc0170 Can you restart the travis check? Seems to have failed on connection error.

Restarted. Please use @ARMmbed/mbed-os-maintainers , anyone from the team should be able to help here

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

Sorry, I checked that tar xf astyle_3.1_linux.tar.gz actually works fine on my machine. It must be a corrupted tar.gz file, then...

It's been working for some months.. I suspect something is wrong with s3. Package has not been updated to my knowledge. I am creating a new issue to fix this

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

Created tracking issue for it #8322 . The archive on s3 seems to be corrupted

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

Created tracking issue for it #8322 . The archive on s3 seems to be corrupted

Fixed

@0xc0170 0xc0170 changed the title unittests: Added tests for netsocket classes unittests: Add tests for netsocket classes Oct 4, 2018
@0xc0170 0xc0170 requested a review from a team October 4, 2018 15:34
0xc0170
0xc0170 requested changes Oct 5, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review astyle (requesting changes)

@michalpasztamobica
unittests: Added tests for netsocket classes
5b4634a 
New classes covered with unit tests: SocketAddress, EthernetInterface, EMACInterface, WiFiAccessPoint.
Also added missing namespace in front of mbed::Callback usages.
EMACInterface is covered by the EthernetInterface unit tests.
@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

@0xc0170 Mind re-reviewing?

@cmonr
Copy link
Contributor

cmonr commented Oct 10, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

Build : SUCCESS

Build number : 3308
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8316/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

Exporter Build : SUCCESS

Build number : 2941
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8316/

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2018

Test : SUCCESS

Build number : 3115
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8316/3115

@cmonr cmonr merged commit 21b4eca into ARMmbed:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michalpasztamobica @SeppoTakalo @0xc0170 @cmonr @mbed-ci