-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase background stack size to fix overflows #8551
Conversation
This is one possible fix for #8184 |
There is no condition on TICKLESS ? |
Right now this patch bumps the background stack size regardless of if tickless is on. If this is too much overhead I could make two configs - one for with tickless and one for without. |
We have few devices with limited RAM, I am 90% sure we will see failures in CI for those specific targets, but in few test we skip if enough memory is not available. Good to have it configurable |
19ef943
to
508662b
Compare
I updated this PR to only increase the background stack size when tickless is enabled. |
/morph build |
Build : FAILUREBuild number : 3554 |
Please review the build failures. Few small targets fail for IAR (placement errors) |
On platforms using both tickless and the low power ticker wrapper so much of the background stack is used that it overflows. To ensure the background thread's stack doesn't overflow increase this size by 256 bytes when tickless is enabled. Worst case usage on the NUCLEO_F476RG was recorded at 656 when tickless is turned on so this increased size should safely prevent overflows.
508662b
to
9613e0f
Compare
I updated this PR so the background thread stack is only increased if both |
/morph build |
Build : SUCCESSBuild number : 3565 Triggering tests/morph test |
Exporter Build : FAILUREBuild number : 3172 |
/morph export-build |
Test : SUCCESSBuild number : 3345 |
Exporter Build : FAILUREBuild number : 3178 |
Note: This PR is now a part of a rollup PR (#8675). Jenkins CI export nodes experienced many drops throughout the day causing false failures. In an attempt to get those PRs through CI, while keeping CI load low, several PRs have been bundled into a single rollup PR. If any more commits are made in this PR, this PR will remain open and have to go through CI on its own. |
Description
On platforms using both tickless and the low power ticker wrapper so much of the background stack is used that it overflows. To ensure the background thread's stack doesn't overflow in any configuration increase this size by 256 bytes. Worst case usage on the NUCLEO_F476RG was recorded at 656 when tickless is turned on so this increased size should safely prevent overflows.
Pull request type