Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phy drivers: Added S2-LP driver #8585

Merged
merged 5 commits into from
Nov 1, 2018
Merged

Conversation

JarkkoPaso
Copy link

Description

STM S2-LP driver added.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2018

One question as I've done most of the components we have. Does this have astyle run ? If not , can you run it on this component?

@0xc0170 0xc0170 requested a review from a team October 30, 2018 12:42
@JarkkoPaso
Copy link
Author

@0xc0170 I ran astyle manually

@JarkkoPaso
Copy link
Author

@mikter @juhhei01 please review

@SeppoTakalo
Copy link
Contributor

LICENSE and apache-2.0.txt are not needed.

It is enough that files have the Apache license preamble.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 I ran astyle manually

👍

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 30, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2018

Build : FAILURE

Build number : 3506
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8585/

@cmonr
Copy link
Contributor

cmonr commented Oct 31, 2018

@JarkkoPaso Please take a look at the build failures.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 31, 2018

@JarkkoPaso Assuming this was rebased to resolve the build failures earlier (worth leaving a comment when you do it)

/morph build

@JarkkoPaso
Copy link
Author

@0xc0170 Yep, thanks!

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

Build : SUCCESS

Build number : 3520
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8585/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 31, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 1, 2018

@cmonr cmonr merged commit 8d014bc into ARMmbed:master Nov 1, 2018
@kjbracey
Copy link
Contributor

This added a bunch of warnings to the build, using deprecated Thread methods. Could you please update as per changes made to the other RF drivers in #7980.

@JarkkoPaso
Copy link
Author

@kjbracey-arm Ok, I'll update this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants