Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix licensing #8641

Merged
merged 10 commits into from
Nov 7, 2018
Merged

Fix licensing #8641

merged 10 commits into from
Nov 7, 2018

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 5, 2018

Description

Updating readme file to define better the license and contributions. This is one of few PR that address license and contributions.
Please review

Note, the change in the Contributing is just spaces. Locally the spaces there were displayed as non ascii characters so I fixed that.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 requested a review from a team November 6, 2018 09:51
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Amanda Butler added 3 commits November 6, 2018 13:47
Remove unnecessary commas, and standardize heading capitalization.
Remove unnecessary comma.
Remove unnecessary comma.
@cmonr
Copy link
Contributor

cmonr commented Nov 7, 2018

Note: This PR is now a part of a rollup PR (#8663).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit 44aaad4 into ARMmbed:master Nov 7, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 7, 2018
@cmonr cmonr removed the rollup PR label Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants