Add a new target DELTA_DFCM_NNN40 #866

Marcomissyou · 2015-01-27T08:23:58Z

Hi,

There is a new target( DELTA_DFCM_NNN40 ) that we want to add into your platform.
We are Delta company. And We manufacture a BLE WiFi combo module.
We use NRF51822 BLE+M0 chip. It is configured to 32MHz X'tal and use 32K RC crystal oscillator.
The module supports OTA update FW so it is necessary to create another target to support OTA like Nordic nRF51822 FOTA.

Thanks
Marco

…ice.h, PinNames

Merge remote-tracking branch 'upstream/master' Conflicts: libraries/mbed/targets/hal/TARGET_NORDIC/TARGET_MCU_NRF51822/i2c_api.c workspace_tools/targets.py

0xc0170 · 2015-01-27T13:12:58Z

workspace_tools/muts_all.json

+            "disk":"F:\\",
+            "peripherals": ["24LC256"]
+    }
+}


This file should probably not be checked in

…erit from NRF51822, add SWIO default setting in system_nrf51822.c and SWIO,VERF pin in PinName.h

Marcomissyou · 2015-01-29T06:07:35Z

libraries/mbed/targets/cmsis/TARGET_NORDIC/TARGET_MCU_NRF51822/system_nrf51822.c

+                                        | (GPIO_PIN_CNF_INPUT_Disconnect << GPIO_PIN_CNF_INPUT_Pos)
+                                        | (GPIO_PIN_CNF_DIR_Output << GPIO_PIN_CNF_DIR_Pos);
+
+	NRF_GPIO->OUTCLR 		= 	(GPIO_OUTCLR_PIN19_Clear << GPIO_OUTCLR_PIN19_Pos);


In the DELTA DFCM_NNN40 module, the pin 19 is connected a RF switch, that controls antenna to radiate Bluetooth 4.0 or WiFi. Pull low to select Bluetooth 4.0 and Pull high to select WiFi.
We define the default setting is pull low to select Bluetooth 4.0.

There's mbed init which is called after the main, where you can implement specific target functionality, like this. I would move this gpo pin change there.

0xc0170 · 2015-01-29T07:19:01Z

There are some missing pieces.

gpio pin target specific code move from SystemInit to mbed_sdk_init()
add export support for gcc arm (to be able to export a code and run tests for example)
online IDE runs on ARM compiler therefore ARM/uARM support is essential

You can send a separate pull request for above. I can merge this now as it is, but first, can you sign http://developer.mbed.org/contributor_agreement/ ?

…ystem_nrf51822.c

…sion4_deta_dfcm_nnn40.uvproj.tmpl

Marcomissyou · 2015-01-30T05:55:28Z

What do I need to do now? wait?
merge by myself?
Thank you very much!

0xc0170 · 2015-01-30T06:26:35Z

I see you added those changes, can you please edit years in files you edited? Like in the mbed overrides file, it states 2014 but was created a day ago. Same applies to files you edited, extend the year.

One more, each toolchain has own script file where is a list of targets supported. Please add yours there, to gcc and uvision.

…mbed_overrides.c,targets.py

0xc0170 · 2015-01-30T07:11:25Z

Please correct the indentation in target.py. The error from Travis build:

 self.supported_toolchains = ["ARM", "GCC_ARM"]
^
IndentationError: unexpected indent

Plus add your target here https://github.com/mbedmicro/mbed/blob/master/workspace_tools/export/gccarm.py and same for uvision

Marcomissyou · 2015-01-30T07:31:20Z

Do I miss some thing?
Can I remove "self.supported_toolchains = ["ARM", "GCC_ARM"]"?
Like HRM1017 platform, we are the same, we all inherit NRF51822. and NRF51822 supported ARM and GCC_ARM.

…elta_dfcm_nnn40.uvopt.tmpl

0xc0170 · 2015-01-30T07:36:31Z

Yes ,you can remove it

Marcomissyou · 2015-01-30T07:50:40Z

Great! Thank you very much 0xc0170
What do I do next?

0xc0170 · 2015-01-30T08:06:22Z

I'll merge this today.

You can test your exporters, if everything works from master, like blinky and some other tests which are there.

Marcomissyou · 2015-01-30T08:26:30Z

ok, thanks

Marcomissyou · 2015-02-02T00:55:25Z

I don't see our target on mbed repository yet.
has it merged?

0xc0170 · 2015-02-02T07:24:55Z

It's going to be merged within minutes. I did not have time on Friday to finish merging, thanks for understanding.

Add a new target DELTA_DFCM_NNN40

ytsuboi · 2015-02-05T18:17:34Z

@Marcomissyou Hey, please be careful not to break other's platform. HRM1017 got problem by your pull request.

Marcomissyou · 2015-02-06T01:29:10Z

Hi,

I apologize for that.
I think it happen in system_nrf51822.c.
#ifdef TARGET_DELTA_DFCM_NNN40 || TARGET_HRM1017Do I need to fix it?

Sorry

2015-02-06 2:17 GMT+08:00 ytsuboi notifications@github.com:

@Marcomissyou https://github.com/Marcomissyou Hey, please be careful
not to break other's platform. HRM1017 got problem by your pull request.

—
Reply to this email directly or view it on GitHub
#866 (comment).

xiongyihui · 2015-02-06T01:29:30Z

libraries/mbed/targets/cmsis/TARGET_NORDIC/TARGET_MCU_NRF51822/system_nrf51822.c

@@ -67,7 +71,7 @@ void SystemInit(void)

    // Start the external 32khz crystal oscillator.

-#ifdef TARGET_HRM1017
+#ifdef TARGET_DELTA_DFCM_NNN40 || TARGET_HRM1017


should be

#if defined(TARGET_DELTA_DFCM_NNN40) || defined(TARGET_HRM1017)

ytsuboi · 2015-02-06T03:21:40Z

Yes, as @xiongyihui wrote, that is the point. The patch for this issue was already sent.
Please note, typical mbed library release is monthly. This means, HRM1017 users need to roll back mbed SDK version on online compiler for a month.
Please be careful to edit shared codes.

ytsuboi · 2015-02-06T03:59:21Z

I wondered why preprocessor didn't notice, so tried reproduction.

[Warning] system_nrf51822.c@71: #14-D: extra text after expected end of preprocessing directive

It caused a warning! Why did you ignore this?
Do not place a pull-request until every error/warning was solved, please.

Marcomissyou · 2015-02-06T04:19:20Z

Hi ytsuboi,

I am not familiar with github, this is my first time to use it and first pull request to mbed repository.
So I apologize again for this unfortunately situation.
I did not see the warning message. Please tell me where to check the warning message?
I will be more very carefully.
Sorry.

ytsuboi · 2015-02-06T05:09:24Z

Okay. :-)
When you run workspace_tools\build.py, your compiler will show the message.

Marcomissyou · 2015-02-06T05:31:59Z

Yes, I saw that warning.
Thank you for telling me.

0xc0170 · 2015-02-06T08:27:51Z

I overlooked it also 😟

Addition to warnings checking, It is a good practise to keep checking pull requests, to minimize this type of issues as one pull request can impact more targets, or even common code. I keep PR open for a while, for comments.

Marcomissyou added 7 commits October 7, 2014 17:59

Marco add for new target DFCM_NNN40

ab92dec

modify i2c_api, analog_api, system_brf51822.c, targets/py and add dev…

66a5f71

…ice.h, PinNames

solve conflict targets.py and i2c_api.c

4a52c80

Merge remote-tracking branch 'upstream/master' Conflicts: libraries/mbed/targets/hal/TARGET_NORDIC/TARGET_MCU_NRF51822/i2c_api.c workspace_tools/targets.py

remove older target

7b4f177

delet rtc_api.c

f578ea3

remove DFCM_NNN40 PinMap_ADC

48aed8e

modify main.cpp of analog and analog_in

e7c32af

0xc0170 reviewed Jan 27, 2015
View reviewed changes

workspace_tools/muts_all.json

"disk":"F:\\",

"peripherals": ["24LC256"]

}

}

Copy link

Contributor

0xc0170 Jan 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should probably not be checked in

0xc0170 added the needs: work label Jan 27, 2015

remove json, delete toolchain list in target.py because NNN40 is inh…

04937dc

…erit from NRF51822, add SWIO default setting in system_nrf51822.c and SWIO,VERF pin in PinName.h

Marcomissyou reviewed Jan 29, 2015
View reviewed changes

Marcomissyou added 2 commits January 29, 2015 16:00

add SWIO setting in mbed_overrides.c to substitute SWIO setting in s…

232821b

…ystem_nrf51822.c

gcc_arm_delta_dfcm_nnn40.tmpl uvision4_deta_dfcm_nnn40.uvopt.tmpl uvi…

ee9d3cf

…sion4_deta_dfcm_nnn40.uvproj.tmpl

extend year and add toolchain system_nrf51822.c, PinNames.h,device.h,…

64465b6

…mbed_overrides.c,targets.py

add target NNN40 in uvision4.py and gccarm.py

1b4c6f8

correct filename uvision4_delta_dfcm_nnn40.uvproj.tmpl and uvision4_d…

69a98d7

…elta_dfcm_nnn40.uvopt.tmpl

remove self.supported_toolchains description

f2a04da

0xc0170 added a commit that referenced this pull request Feb 2, 2015

Merge pull request #866 from Marcomissyou/master

9f80c90

Add a new target DELTA_DFCM_NNN40

0xc0170 merged commit 9f80c90 into ARMmbed:master Feb 2, 2015

0xc0170 removed the needs: work label Feb 2, 2015

xiongyihui reviewed Feb 6, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add a new target DELTA_DFCM_NNN40 #866

Add a new target DELTA_DFCM_NNN40 #866

Marcomissyou commented Jan 27, 2015

0xc0170 Jan 27, 2015

Marcomissyou Jan 29, 2015

0xc0170 Jan 29, 2015

0xc0170 commented Jan 29, 2015

Marcomissyou commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

Marcomissyou commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

Marcomissyou commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

Marcomissyou commented Jan 30, 2015

Marcomissyou commented Feb 2, 2015

0xc0170 commented Feb 2, 2015

ytsuboi commented Feb 5, 2015

Marcomissyou commented Feb 6, 2015

xiongyihui Feb 6, 2015

ytsuboi commented Feb 6, 2015

ytsuboi commented Feb 6, 2015

Marcomissyou commented Feb 6, 2015

ytsuboi commented Feb 6, 2015

Marcomissyou commented Feb 6, 2015

0xc0170 commented Feb 6, 2015

Add a new target DELTA_DFCM_NNN40 #866

Add a new target DELTA_DFCM_NNN40 #866

Conversation

Marcomissyou commented Jan 27, 2015

0xc0170 Jan 27, 2015

Choose a reason for hiding this comment

Marcomissyou Jan 29, 2015

Choose a reason for hiding this comment

0xc0170 Jan 29, 2015

Choose a reason for hiding this comment

0xc0170 commented Jan 29, 2015

Marcomissyou commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

Marcomissyou commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

Marcomissyou commented Jan 30, 2015

0xc0170 commented Jan 30, 2015

Marcomissyou commented Jan 30, 2015

Marcomissyou commented Feb 2, 2015

0xc0170 commented Feb 2, 2015

ytsuboi commented Feb 5, 2015

Marcomissyou commented Feb 6, 2015

xiongyihui Feb 6, 2015

Choose a reason for hiding this comment

ytsuboi commented Feb 6, 2015

ytsuboi commented Feb 6, 2015

Marcomissyou commented Feb 6, 2015

ytsuboi commented Feb 6, 2015

Marcomissyou commented Feb 6, 2015

0xc0170 commented Feb 6, 2015