Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a bug in the FVP platform where flash API page size was wrong #8692

Merged
merged 1 commit into from
Nov 14, 2018
Merged

fix a bug in the FVP platform where flash API page size was wrong #8692

merged 1 commit into from
Nov 14, 2018

Conversation

jamesbeyond
Copy link
Contributor

Description

fix a bug in the FVP platform where flash API page size was wrong.

Was mistaken page size as block size.
This issue cause the Pelion Cloud Client SOTP initialization failed.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@jamesbeyond
Copy link
Contributor Author

Flash related test result attached

+---------------------+---------------+----------------------------------------------------------+----------------------------------------+--------+--------+--------+--------------------+
| target              | platform_name | test suite                                               | test case                              | passed | failed | result | elapsed_time (sec) |
+---------------------+---------------+----------------------------------------------------------+----------------------------------------+--------+--------+--------+--------------------+
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device | FlashSimBlockDevice functionality test | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - init                        | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program                     | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program across sectors      | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program errors              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - timing                      | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - clock and cache test           | 1      | 0      | OK     | 0.06               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - erase sector                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - init                           | 1      | 0      | OK     | 0.04               |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - mapping alignment              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-ARM     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - program page                   | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device | FlashSimBlockDevice functionality test | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - init                        | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program                     | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program across sectors      | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program errors              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - timing                      | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - clock and cache test           | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - erase sector                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - init                           | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - mapping alignment              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-GCC_ARM | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - program page                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | features-storage-tests-blockdevice-flashsim_block_device | FlashSimBlockDevice functionality test | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - init                        | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program                     | 1      | 0      | OK     | 0.06               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program across sectors      | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - program errors              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_drivers-flashiap                              | FlashIAP - timing                      | 1      | 0      | OK     | 0.02               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - clock and cache test           | 1      | 0      | OK     | 0.03               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - erase sector                   | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - init                           | 1      | 0      | OK     | 0.01               |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - mapping alignment              | 1      | 0      | OK     | 0.0                |
| FVP_MPS2_M3-IAR     | FVP_MPS2_M3   | tests-mbed_hal-flash                                     | Flash - program page                   | 1      | 0      | OK     | 0.0                |
+---------------------+---------------+----------------------------------------------------------+----------------------------------------+--------+--------+--------+--------------------+

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

@jamesbeyond Why is string.h now needed as well?

@jamesbeyond
Copy link
Contributor Author

@cmonr, It is not compulsory, I just included them the suppress the compiler warning messages for the memset()/memcpy()

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 12, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 12, 2018

Build : SUCCESS

Build number : 3606
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8692/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 13, 2018

Exporter Build : SUCCESS

Build number : 3210
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8692/

@mbed-ci
Copy link

mbed-ci commented Nov 13, 2018

Test : FAILURE

Build number : 3382
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8692/3382

@0xc0170 0xc0170 mentioned this pull request Nov 13, 2018
Closed
@cmonr cmonr mentioned this pull request Nov 13, 2018
Merged
@cmonr
Copy link
Contributor

cmonr commented Nov 13, 2018

Note: This PR is now a part of a rollup PR (#8733).

In order to expidite remaining CI testing, this PR has been bundled into the above rollup PR.

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit f7ff09d into ARMmbed:master Nov 14, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 14, 2018
@cmonr cmonr removed the rollup PR label Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jamesbeyond @cmonr @0xc0170 @mbed-ci