Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new PSA Internal Trusted Storage APIs #8730

Merged
merged 4 commits into from
Nov 26, 2018
Merged

Add a new PSA Internal Trusted Storage APIs #8730

merged 4 commits into from
Nov 26, 2018

Conversation

danny4478
Copy link
Contributor

@danny4478 danny4478 commented Nov 13, 2018 •
edited by NirSonnenschein
Loading

Description

PSA-ITS over kvstore for single core targets only.
Mainly targeted to PSA-Crypto usage.
Should be merged after #8667 and #8680 in this order.

Note

Please refer to the last three commits only.
The others (first 4) commits have their own PRs.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[X] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@cmonr cmonr requested a review from bulislaw November 13, 2018 21:36
alzix
alzix suggested changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@alzix alzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my review comments

@netanelgonen netanelgonen mentioned this pull request Nov 14, 2018
Closed
alzix
alzix approved these changes Nov 14, 2018
View reviewed changes
Copy link
Contributor

@alzix alzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This was referenced Nov 14, 2018
Merged
Merged
@NirSonnenschein NirSonnenschein requested a review from a team November 15, 2018 07:13
@mikisch81
Copy link
Contributor

Rebased with master branch

NirSonnenschein
NirSonnenschein reviewed Nov 18, 2018
View reviewed changes
Copy link
Contributor

@NirSonnenschein NirSonnenschein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to me , but please look at the license headers comment

TESTS/psa/prot_internal_storage/its_reset/COMPONENT_PSA_SRV_EMUL/test_pits.c Show resolved Hide resolved
@NirSonnenschein NirSonnenschein requested a review from a team November 18, 2018 16:27
@cmonr cmonr mentioned this pull request Nov 20, 2018
Merged
@mohammad1603 mohammad1603 mentioned this pull request Nov 21, 2018
Merged
bulislaw
bulislaw reviewed Nov 22, 2018
View reviewed changes
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is PSA hidden behind TARGET_ but in components directory? @alzix

@mikisch81
Copy link
Contributor

@bulislaw TARGET_PSA filter the non-PSA-compliant devices, which are devices with not enough flash for hosting internal storage, flahAIP drivers and TDBStore.
The COMPONENT_* filter filters the components of the PSA target between NSPE PSA targets which will have for example the NSPE and PSA_IPC_EMUL** components and SPE PSA targets which will have SPE component, there is an RFC regarding this which was thoroughly discussed, see https://github.com/ARMmbed/Mbed-PSA-Services-Docs/blob/master/build-system/rfc.md.

This was referenced Nov 23, 2018
Closed
Merged
@alzix
Copy link
Contributor

alzix commented Nov 25, 2018

@NirSonnenschein please trigger CI

@NirSonnenschein
Copy link
Contributor

@alzix it is running now

@mbed-ci
Copy link

mbed-ci commented Nov 25, 2018

Test run: SUCCESS

Summary: 4 of 4 test jobs passed
Build number : 11
Build artifacts
Build logs

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

@bulislaw Please final review

@0xc0170 0xc0170 merged commit fdca1e3 into ARMmbed:master Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alzix alzix alzix approved these changes

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danny4478 @mikisch81 @alzix @NirSonnenschein @mbed-ci @0xc0170 @bulislaw @cmonr @adbridge