Fix build of library archive with Arm Compiler 6 #8840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'archive' method of the toolchain class 'ARM' expects that self.ar is a string, but the constructor of the class 'ARMC6' initializes it with a list. This patch fixes the issue.
Contributor
|
Thanks for the contribution. We assigned reviewers who will review soon. |
bridadan
approved these changes
Nov 26, 2018
Contributor
bridadan
left a comment
bridadan
left a comment
There was a problem hiding this comment.
Looks good to me. Might be worth a double check from @theotherjimmy.
theotherjimmy
approved these changes
Nov 26, 2018
cmonr
added
needs: CI
release-version: 5.11.0-rc1
risk: G
and removed
needs: review
labels
Contributor
|
CI started. |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
cmonr
added
ready for merge
needs: CI
risk: G
and removed
needs: CI
ready for merge
risk: G
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The 'archive' method of the toolchain class 'ARM' expects that self.ar
is a string, but the constructor of the class 'ARMC6' initializes it
with a list. This patch fixes the issue.
Pull request type