Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add core option for Cortex-M33 with DSP enabled #8995

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Add core option for Cortex-M33 with DSP enabled #8995

merged 1 commit into from
Dec 12, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

This is the update for Issue #8992

Pull request type

[] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mmahadevan108
Copy link
Contributor Author

cc @deepikabhavnani @0xc0170 @cmonr @maclobdell

@deepikabhavnani
Copy link

@gaborkertesz @jeromecoutant @ccli8 - Please see, if changes impact your ARMv8M devices.

deepikabhavnani
deepikabhavnani reviewed Dec 6, 2018
View reviewed changes
tools/toolchains/arm.py Outdated
@@ -418,20 +423,27 @@ def __init__(self, target, *args, **kwargs):
self.flags['common'].append("-march=armv8-m.base")
elif target.core.startswith("Cortex-M33F"):
self.flags['common'].append("-mfpu=fpv5-sp-d16")
self.flags['common'].append("-mfloat-abi=softfp")
self.flags['common'].append("-mfloat-abi=hard")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure of hard floating point. @TacoGrandeTX @theotherjimmy - Do you have any suggestions for floating option in ARMv8M? I see we have always selected soft floating point for v6 / v7 architecture.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have selected softfp

@deepikabhavnani
Copy link

@mmahadevan108 - Please add similar changes for GCC toolchain as well

@mmahadevan108
Copy link
Contributor Author

This PR has changes to gcc.py for the GCC toolchain

theotherjimmy
theotherjimmy suggested changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@theotherjimmy theotherjimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

softfp is used for all other floating point code in else.

tools/toolchains/gcc.py Outdated Show resolved Hide resolved
@mmahadevan108
Add core option for Cortex-M33 with DSP enabled
f05e7b7 
Signed-off-by: Deepika Bhavnani <Deepika.Bhavnani@arm.com>
Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
deepikabhavnani
deepikabhavnani approved these changes Dec 7, 2018
View reviewed changes
Copy link

@deepikabhavnani deepikabhavnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

@ARMmbed/mbed-os-maintainers - PR should be tested locally by other ARMv8M targets before merge.

@gaborkertesz @LMESTM @jeromecoutant @ccli8 - Please let us know if this PR breaks anything.

@ccli8
Copy link
Contributor

ccli8 commented Dec 10, 2018

@deepikabhavnani This PR is OK for M2351 Greentea test.

@cmonr
Copy link
Contributor

cmonr commented Dec 10, 2018

CI started

@cmonr
Copy link
Contributor

cmonr commented Dec 11, 2018 •
edited
Loading

CI job stopped: jenkins-ci/exporter

Prioritizing RC3 PRs. Will restart when able.

@mbed-ci
Copy link

mbed-ci commented Dec 11, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Dec 12, 2018

CI restarted: jenkins-ci/exporter

@0xc0170 0xc0170 removed the needs: CI label Dec 12, 2018
@0xc0170 0xc0170 merged commit 93da33f into ARMmbed:master Dec 12, 2018
@deepikabhavnani deepikabhavnani mentioned this pull request Dec 12, 2018
Closed
@mmahadevan108 mmahadevan108 deleted the Update_for_M33_FD branch December 13, 2018 20:09
@mmahadevan108 mmahadevan108 mentioned this pull request Dec 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theotherjimmy theotherjimmy theotherjimmy approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

@cmonr cmonr Awaiting requested review from cmonr

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmahadevan108 @deepikabhavnani @ccli8 @cmonr @mbed-ci @theotherjimmy @0xc0170