Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing socket greentea tests implementation #9001

Merged
merged 1 commit into from
Dec 9, 2018

Conversation

michalpasztamobica
Copy link
Contributor

Description

The TCP/UDP socket tests status is now fully in line with the test plan, with the exception of missing getsockopt implementation in LWIP stack.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

@michalpasztamobica
Copy link
Contributor Author

@SeppoTakalo , @VeijoPesonen , @KariHaapalehto , please review.

@SeppoTakalo
Copy link
Contributor

Check the Astyle errors.

@SeppoTakalo
Copy link
Contributor

Also.. Do we want this to be copy&pasted on every single test case:

#if MBED_CONF_NSAPI_SOCKET_STATS_ENABLE
    int count = fetch_stats();
    for (int j = 0; j < count; j++) {
        TEST_ASSERT_EQUAL(SOCK_CLOSED,  tcp_stats[j].state);
    }
#endif

I'm fine for it now, but feel like we should refactor socket stats to its own test, so there would be less boilerplate to copy&paste on every single test case.

@michalpasztamobica
Copy link
Contributor Author

Astyle fixed, I created an internal task ONME-4070, to make sure we refactor the socket stats.

@ciarmcom ciarmcom requested review from a team December 7, 2018 10:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 7, 2018

@michalpasztamobica, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward.

@cmonr
Copy link
Contributor

cmonr commented Dec 7, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 7, 2018

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 9d28c3f into ARMmbed:master Dec 9, 2018
@cmonr cmonr removed the needs: CI label Dec 9, 2018
@michalpasztamobica michalpasztamobica deleted the greentea_missing_tests branch August 22, 2019 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants