Cellular: Rewrite AT handler consume to tag #9052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sequence from buffer contains tag but symbol before tag is same as first symbol of the tag, then the tag wasn't detected. For example, "\r\n" tag was not found from "\r\r\nOK" sequence.
mirelachirica
force-pushed
the
at_handler_fix_consume_to_stop_tag
branch
from
b7fbc2b
to
806e95c
Compare
|
@mirelachirica, thank you for your changes. |
cmonr
approved these changes
Dec 11, 2018
jarvte
approved these changes
Dec 12, 2018
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Restarted dynamic usage error (wifi timeouted) |
|
All green, ready for merge |
|
How to choose between ATHandler and platform/ATCmdParser ? Thanks for your help ! |
@ARMmbed/mbed-os-wan Please review |
|
@prowan Please open a new issue in Mbed OS (https://github.com/ARMmbed/mbed-os/issues) since we generally ignore PRs after they're merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressing issue: #9014
There is need to refactor the solution to the problem addressed in commit:
31f153a
Pull request type