Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add socket stat logging state change update #9079

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Add socket stat logging state change update #9079

merged 1 commit into from
Dec 18, 2018

Conversation

kegilbert
Copy link
Contributor

Description

TCPServer was deprecated and the accept call was added to TCPSocket. Add state change update to that call for Socket stats reporting.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@deepikabhavnani
Copy link

@kegilbert - Even peer should be updated
https://github.com/ARMmbed/mbed-os/blob/master/features/netsocket/TCPServer.cpp#L56

@kegilbert
Copy link
Contributor Author

Ah, right good catch thanks!

@kegilbert kegilbert force-pushed the TCPSocket-accept-statelog branch 2 times, most recently from d80850c to c6b97b5 Compare December 13, 2018 20:48
@kegilbert
Add socket stat logging state change update
ee3945d 
TCPServer was deprecated and the accept call was added to TCPSocket. Add state change update to that call
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 14, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 15, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_exporter

@cmonr
Copy link
Contributor

cmonr commented Dec 15, 2018

Will need to restart jenkins-ci/exporter a bit later. The job ended up getting stuck.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 17, 2018

Exporters restarted

@cmonr
Copy link
Contributor

cmonr commented Dec 17, 2018

Hmm, not sure the exporter was restarted. Will restart in a bit.

@cmonr
Copy link
Contributor

cmonr commented Dec 17, 2018

CI Job restarted: jenkins-ci/exporter

@0xc0170 0xc0170 merged commit 06748af into ARMmbed:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@deepikabhavnani deepikabhavnani deepikabhavnani approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kegilbert @deepikabhavnani @0xc0170 @mbed-ci @cmonr @SeppoTakalo