Fix LTO build failures due to duplicate local types #9158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjbracey
approved these changes
Dec 19, 2018
0xc0170
approved these changes
Dec 19, 2018
|
It might be useful to extend the code guidelines to mention that data structures local to a C++ files should be declared inside an anonymous namespace. @kjbracey-arm What do you think ? |
|
Absolutely. It's a "must", rather than a "should", even. |
|
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
This is ready for integration I created tracking issue for docs update ARMmbed/mbed-os-5-docs#884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes failures in build when using LTO (Link Time Optimizations) in the GCC_ARM toolchain. Failures are caused by local types having similar names and different content (like structures with similar names and different fields). Solution is achieved by wrapping these types with the anonymous namespace.
Resolves #9099.
Pull request type