Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to unit test losing process output due to timing issue #9168

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Fix to unit test losing process output due to timing issue #9168

merged 1 commit into from
Dec 24, 2018

Conversation

JuhPuur
Copy link
Contributor

@JuhPuur JuhPuur commented Dec 20, 2018

Description

The loop would read lines until the child process terminated, but if the process terminated before every line was read we would lose output and the testing person might have concluded that no tests were run after that point. This fixes that by reading the remnant after the child process terminates.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@ciarmcom
Copy link
Member

@JuhPuur, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team December 20, 2018 10:00
@0xc0170 0xc0170 requested a review from a team December 20, 2018 11:35
@cmonr
Copy link
Contributor

cmonr commented Dec 20, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 20, 2018

Test run: FAILED

Summary: 1 of 1 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_unittests

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2018

Please review the failure [linux] TypeError: __init__() got an unexpected keyword argument 'encoding'

@JuhPuur
Copy link
Contributor Author

JuhPuur commented Dec 21, 2018

Fixed it. I was testing with python 3.7 and forgot to revert. subprocess module has that argument in later versions.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 21, 2018

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2018

Test run: SUCCESS

Summary: 9 of 9 test jobs passed
Build number : 2
Build artifacts

@adbridge adbridge merged commit 1d230c1 into ARMmbed:master Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants