Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTB_ODIN_v2_fixes #9174

Merged
merged 1 commit into from
Dec 22, 2018
Merged

MTB_ODIN_v2_fixes #9174

merged 1 commit into from
Dec 22, 2018

Conversation

ashok-rao
Copy link
Contributor

Description

Fixes to MTB_ODIN target based on v2.0.0 of the MCB hardware:

  1. Removed redundant code comments. Added relevant ones for MTB pins.
  2. More SPI_CS pins added for peripherals on the MTB.
  3. Disabled LSE_Clock as it is not present on the MTB in targets.json

@0xc0170 , @cmonr : Could you please let me know what test results I need to attach for this PR? I've tested a basic blinky that tests the SPI (LCD), I2C (temp sensor) and PWMs (LEDs) on the MTB & it is working fine. Thanks.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@cmonr @0xc0170 : Could you please review? Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2018

Can you add the list from description to the commit msg ?

v2.0.0 - what for users with older revision, or only 2.0.0 out there?

@ashok-rao
Copy link
Contributor Author

Thanks @0xc0170 .. only v2.0.0 going out.. earlier version was for internal development only..

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 20, 2018

IF you can extend the commit message to contain details that are provided here, we will start CI

@ciarmcom ciarmcom requested review from 0xc0170, cmonr and a team December 20, 2018 14:00
@ciarmcom
Copy link
Member

@ashok-rao, thank you for your changes.
@cmonr @0xc0170@ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve the commit message as requested above

@cmonr
Copy link
Contributor

cmonr commented Dec 20, 2018

@ashok-rao If there are any tests that run LSE_Clock, would be good to check that those are no logner run.

Otherwise, I'm not sure which tests would test the SPI pins.

1. Removed redundant code comments. Added relevant ones for MTB pins.
2. More SPI_CS pins added for peripherals on the MTB.
3. Disabled LSE_Clock as it is not present on the MTB in targets.json
@ashok-rao
Copy link
Contributor Author

ashok-rao commented Dec 21, 2018

@0xc0170 : Force pushed with changes to commit message :-)
@cmonr : Some of the RTC tests used the LSE Clock. There is an internal JIRA : https://jira.arm.com/browse/IOTPART-7257 ongoing for this too.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 21, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit a8fa6ec into ARMmbed:master Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants