Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "STM32 RTC : skip rtc_write if possible" #9180

Merged
merged 1 commit into from
Dec 24, 2018
Merged

Revert "STM32 RTC : skip rtc_write if possible" #9180

merged 1 commit into from
Dec 24, 2018

Commits on Dec 21, 2018

  1. Revert "STM32 RTC : skip rtc_write if possible" 

    `rtc_write` must start the RTC. `time()` uses `rtc_write(0)` to start
the RTC if it is not already enabled, but this check made that not
work.

There's no point trying to optimise this case in a HAL - if we wanted
`set_time()` to protect against users making pointless adjustments, the
implementation should be there. But even then, you might want different
levels of hysteresis depending on application, so it's probably best
left to applications.

This reverts commit 9da5e48.
    @kjbracey
    kjbracey committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    535b439 View commit details
    Browse the repository at this point in the history