-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GD32_E103VB as new target #9203
Conversation
@ChazJin, thank you for your changes. |
The test results based on MBED OS 5.11 are as follows(WIN10, run "mbed test -t GCC_ARM/ARM/IAR -m GD32_E103VB" directly). GD32E103VB_ARM_5_11.txt |
Is this merging latest master changes to your branch? Can this be eliminated by doing rebase? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for master merge commit (otherwise code looks fine to me)
I resolve the conflict directly on the web, and I think this should be the latest master change. If you don't think it's appropriate, I'll try ‘git reset’ this commit and rebase it. Is that right? Thanks! @0xc0170 |
Please do, the web interface is not ideal in this case and rather resolve this locally |
I have rebase it and resolve this locally. However, it seems that some error happens which leads to the Travis CI build could not complete in continuous-integration/travis-ci/pr. I would appreciate it if you could give me a few pointer. @0xc0170 |
This was travis error, restarted it |
Waiting for @ashok-rao to review and/or @Ronny-Liu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the device folder be outside of TARGET_GD32E103VB? There are GD32E1xx common file in the device folder.
Ci started |
Restarting Windows node closed its connection too soon. |
Hi @cmonr, I found there is a conflicting file(target.json), I have resolved it and force-pushed gd32e10x branch which means CI test may be re-executed. Sorry for the trouble you've taken. |
@ChazJin Wow, what timing! Commits look good, although I'm puzzled why Travis CI hasn't started. Will start CI once Travis has started and passed. |
Trying a thing. |
Aaand Travis CI picked that up! ...it's been having issues lately... |
CI started |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
NOTICEThis PR is on hold because an issue in the master branch was found when this was rebased. |
PR which adds boot/isr stack size configuration option and unifies boot/isr stack size (PR #9092) has been merged after I have adapted linker scripts of the new target( Please adapt linker scripts in this PR. As a reference what has changed you can check PR #8039 which provides framework for configuring boot stack size and example update of the linker scripts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linker scripts looks good!
Thank you very much. I just adapt linker scripts which refers to your revision and if there are any problems, please point them out. Thanks again for your support. @mprse |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
Pull request type
Reviewers
CC @Ronny-Liu @0xc0170 @ashok-rao please review when you're available, many thanks!