BLE: NRF52 returns used tx/rx phy on phy update callback

[desmond-blue]

Description

The on phy upate callback function of NRF52, which is nRF5xGap::on_phy_update(), doesn't respect to used tx/rx phy, the parameters are hard-coded to LE_1M.

Those parameters should be set according to event from btle_handler()

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

[ciarmcom]

@desmond-blue, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

[pan-]

Thanks for the submission, could you add a conversion function that maps phy values from the nordic domain to the mbed domain ? There is already few conversion functions in the anonymous namespace at the top of the file.

ble::phy_t convert_phy(uint8_t nordic_phy)
{ 
    switch(evt.rx_phy) {
        case BLE_GAP_PHY_1MBPS:
            return ble::phy_t::LE_1M;

        case BLE_GAP_PHY_2MBPS:
            return ble::phy_t::LE_2M;

        case BLE_GAP_PHY_CODED:
            return ble::phy_t::LE_CODED;

        default:
            return ble::phy_t::NONE;
    }
}

// in on_phy_update

    _eventHandler->onPhyUpdateComplete(
        status,
        connection,
        convert_phy(evt.tx_phy),
        convert_phy(evt.rx_phy)
    );

[desmond-blue]

Thanks for the reviewing, I change the code accordingly.

Please re-review. Changes applied.

[cmonr]

👍

[0xc0170]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts