hal-qspi_test: move frequency setting before flash init #9229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maciejbocianski, thank you for your changes. |
0xc0170
approved these changes
Jan 3, 2019
Frequency setting just after erase operation was causing some data inconsistencies during write/read operations on some targets (frdm-k82f). To fix this, frequency setting was moved before flash memory init.
maciejbocianski
force-pushed
the
qspi_hal_test_k82f_fix
branch
from
b43f4c5
to
fc593d2
Compare
|
astyle fixed |
|
Will likely run the greentea tests multiple times to confirm, but this is exciting! |
|
CI started |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for #9075
Frequency setting just after erase operation was causing some data
inconsistencies during write/read operations on some targets (frdm-k82f).
To fix this, frequency setting was moved before flash memory init.
Frankly, setting frequency before every write/read operation was pointless.
Tested on:
DISCO_F769NI
DISCO_F413ZH
DISCO_L475VG_IOT01A
nrf52840_dk
Pull request type
Reviewers
@0xc0170
@ARMmbed/mbed-os-storage
@ARMmbed/mbed-os-hal