Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastModel: update platform header, removed unwanted smsc9220 device #9233

Merged
merged 3 commits into from
Jan 4, 2019

Conversation

jamesbeyond
Copy link
Contributor

Description

  • Removed unwanted smsc9220 device from Platform header definitions.
  • Move the platform header to a common place and share across all the FVP targets
  • rename the platform header from SMM_MPS2.h to FVP_MPS2.h due to FastModel version of MPS2 have minor difference from HW SMM_MPS2 platform

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-hal

@ciarmcom ciarmcom requested a review from a team January 3, 2019 14:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 3, 2019

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

Out of curiosity, why was the SMSC9220 unwanted?

@cmonr
Copy link
Contributor

cmonr commented Jan 3, 2019

CI started

@jamesbeyond
Copy link
Contributor Author

Out of curiosity, why was the SMSC9220 unwanted?

SMSC9220 is in the HW version of MPS2, but not in FastModel version MPS2. FastModel uses SMSC91c111, which already went in mbed-os in previous PR.

@mbed-ci
Copy link

mbed-ci commented Jan 4, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 26833c0 into ARMmbed:master Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants