Increases events.shared-stacksize to 2K #9239
Conversation
|
@VeijoPesonen Out of curiosity, what was causing the current size to be insufficient? |
|
@cmonr unfortunately I don't know what takes the stack space, I only know that the driver will crash to memory exhaustion with the default 1K. |
|
That is not the correct answer.. Correct answer is that ESP8266 driver started to use global event queue to handle some AT parsing and call Therefore we propose that this is raised to 2kB, as the assumption is that event loop should allow as equivalently complex code than any other threads. In Mbed OS, the default Thread stack size is 4kB, but we assume 2kB to be enough for non-blocking event purposes. |
|
@VeijoPesonen Would that be good to be added to the commit msg (^^ answer above) ? |
ESP8266 driver started to use global event queue to handle some AT parsing and call Socket::sigio() events. It turned out that when running DNS tests, or Pelion Client, the stack space (1kB) is not enough for the purpose. Therefore we propose that this is raised to 2kB, as the assumption is that event loop should allow as equivalently complex code than any other threads. In Mbed OS, the default Thread stack size is 4kB, but we assume 2kB to be enough for non-blocking event purposes.
|
@0xc0170 , copied @SeppoTakalo's description to the commit message. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
|
CI restarted. |
Test run: FAILEDSummary: 1 of 7 test jobs failed Failed test jobs:
|
|
We are experiencing CI node failures, few jobs were aborted. We are investigating, will restart the jobs once fixed. cc @ARMmbed/mbed-os-test |
|
Ci restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
This has become as an issue at least with ESP8266.
Description
ESP8266 driver started to use global event queue to handle some AT parsing and call Socket::sigio() events.
It turned out that when running DNS tests, or Pelion Client, the stack space (1kB) is not enough for the purpose.
Therefore we propose that this is raised to 2kB, as the assumption is that event loop should allow as equivalently complex code than any other threads.
In Mbed OS, the default Thread stack size is 4kB, but we assume 2kB to be enough for non-blocking event purposes.
Pull request type
Reviewers
@kjbracey-arm
@SeppoTakalo